Skip to content

Test with latest Bundler - #64

Merged
jenshenny merged 2 commits into
Shopify:mainfrom
deivid-rodriguez:bump-tested-bundler
Apr 2, 2024
Merged

Test with latest Bundler#64
jenshenny merged 2 commits into
Shopify:mainfrom
deivid-rodriguez:bump-tested-bundler

Conversation

@deivid-rodriguez

@deivid-rodriguezdeivid-rodriguez commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

I checked if it passes all tests.

There was an issue, but I fixed it upstream though ruby/rubygems#7066.

@deivid-rodriguez
deivid-rodriguezforce-pushed the bump-tested-bundler branch 2 times, most recently from 7b16540 to 9df490dCompareNovember 10, 2023 11:19
@deivid-rodriguez

Copy link
Copy Markdown
ContributorAuthor

I figured out the issue.

Current tests use plugin as a git source pointing to a branch. However, I think git rev-parse --abbrev-ref HEAD is returning HEAD in CI. Old Bundler dealed with that fine because it cloned full repositories but Bundler 2.4 only clones the revisions needed and HEAD is ambiguous.

I think this is a test-only issue and I changed the tests to use a path source instead to fix that. I think path is more adequate anyways because it allows to test your changes more directly.

@jenshennyjenshenny mentioned this pull request Apr 2, 2024
7 tasks

@jenshennyjenshenny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jenshenny
jenshenny merged commit 2d179a6 into Shopify:mainApr 2, 2024
@deivid-rodriguez
deivid-rodriguez deleted the bump-tested-bundler branch April 3, 2024 11:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@deivid-rodriguez@jenshenny