Skip to content

Use @testing-library/react-native - #277

Merged
markmur merged 1 commit into
mainfrom
markmur/replace-react-test-renderer
Aug 26, 2025
Merged

Use @testing-library/react-native#277
markmur merged 1 commit into
mainfrom
markmur/replace-react-test-renderer

Conversation

@markmur

@markmurmarkmur commented Aug 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What changes are you making?

Adds @testing-library/react-native and updates the context tests.

PR Checklist

Important

Releasing a new version of the kit?

Tip

See the Contributing documentation for instructions on how to publish a new version of the library.

@markmurmarkmur self-assigned this Aug 20, 2025
@markmur
markmur requested a review from a team as a code ownerAugust 20, 2025 11:32
@github-actions

github-actionsBot commented Aug 20, 2025•
edited
Loading

Copy link
Copy Markdown

Coverage Report

LinesStatementsBranchesFunctions
Coverage: 100%
100% (196/196)99.04% (104/105)100% (62/62)

@markmur
markmurforce-pushed the markmur/replace-react-test-renderer branch 2 times, most recently from cf86f99 to 8cc1718CompareAugust 20, 2025 11:37
@markmur
markmurforce-pushed the markmur/replace-react-test-renderer branch from 8cc1718 to c029d80CompareAugust 20, 2025 12:37
kieran-osgood-shopify
kieran-osgood-shopify reviewed Aug 20, 2025
View reviewed changes
Comment threadpackage.json Outdated
"react-native-gesture-handler": "^2.15.0",
"react-native-gradle-plugin": "^0.71.19",
"react-test-renderer": "18.3.1",
"react-test-renderer": "18.2.0",

@kieran-osgood-shopifykieran-osgood-shopifyAug 20, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @testing-library/react-native is a replacement for react-test-renderer - can we remove this dependency?

@markmurmarkmurAug 20, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@testing-library/react-native is built on top of react-test-renderer so it's still required as a peer dependency → https://github.com/callstack/react-native-testing-library/blob/main/package.json#L59

@kieran-osgood-shopifykieran-osgood-shopifyAug 21, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad I always end up on the wrong docs page for @testing-library/react-native

Useful to know - its marked as deprecated from react-native 77 / React19
Once we get to 77 and as of v14 a replacement is in an open PR here: callstack/react-native-testing-library#1705

@markmurmarkmurAug 21, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, looks like they're replacing it with a universal-test-renderer package

@markmur
markmurforce-pushed the markmur/replace-react-test-renderer branch 2 times, most recently from 2ca9d57 to c23c7bfCompareAugust 22, 2025 10:58
@markmur
markmur enabled auto-merge (squash) August 22, 2025 11:33
@markmur
markmurforce-pushed the markmur/replace-react-test-renderer branch from c23c7bf to 04ce4c4CompareAugust 26, 2025 15:44
@markmur
markmurforce-pushed the markmur/replace-react-test-renderer branch from 04ce4c4 to 4d360b7CompareAugust 26, 2025 15:49
kieran-osgood-shopify
kieran-osgood-shopify approved these changes Aug 26, 2025
View reviewed changes

@kieran-osgood-shopifykieran-osgood-shopify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as its a stylistic point - but one benefit of moving to react testing lib is we can use screen queries instead of the destructuring from render https://github.com/testing-library/dom-testing-library/releases/tag/v6.11.0

reduces the amount of changes needed to maintain / experiment with queries

@markmur
markmur merged commit 21d38ca into mainAug 26, 2025
8 checks passed
@markmur
markmur deleted the markmur/replace-react-test-renderer branch August 26, 2025 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kieran-osgood-shopifykieran-osgood-shopifykieran-osgood-shopify approved these changes
@kiftiokiftioAwaiting requested review from kiftio

Assignees

@markmurmarkmur

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markmur@kieran-osgood-shopify
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Use @testing-library/react-native by markmur · Pull Request #277 · Shopify/checkout-sheet-kit-react-native · GitHub
Skip to content
Use @testing-library/react-native - #277
Merged
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Aug 26, 2025
Merged
Use @testing-library/react-native#277
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Conversation
@markmur
@markmurmarkmur
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
What changes are you making?
Adds @testing-library/react-native and updates the context tests.
PR Checklist
Important
Releasing a new version of the kit?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.
@markmurmarkmur
self-assigned this
Aug 20, 2025
@markmur
markmur
requested a review
from a team
as a code ownerAugust 20, 2025 11:32
@github-actions
github-actionsBot
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Coverage Report
LinesStatementsBranchesFunctions
Coverage: 100%
100% (196/196)99.04% (104/105)100% (62/62)
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
cf86f99 to
8cc1718CompareAugust 20, 2025 11:37
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
8cc1718 to
c029d80CompareAugust 20, 2025 12:37
kieran-osgood-shopify
kieran-osgood-shopify
reviewed
Aug 20, 2025
View reviewed changes
Comment threadpackage.json
Outdated

 "react-native-gesture-handler": "^2.15.0",
 "react-native-gradle-plugin": "^0.71.19",
 "react-test-renderer": "18.3.1",
 "react-test-renderer": "18.2.0",
@kieran-osgood-shopifykieran-osgood-shopifyAug 20, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @testing-library/react-native is a replacement for react-test-renderer - can we remove this dependency?
@markmurmarkmurAug 20, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@testing-library/react-native is built on top of react-test-renderer so it's still required as a peer dependency → https://github.com/callstack/react-native-testing-library/blob/main/package.json#L59
@kieran-osgood-shopifykieran-osgood-shopifyAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad I always end up on the wrong docs page for @testing-library/react-native
Useful to know - its marked as deprecated from react-native 77 / React19

Once we get to 77 and as of v14 a replacement is in an open PR here: callstack/react-native-testing-library#1705
@markmurmarkmurAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, looks like they're replacing it with a universal-test-renderer package
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
2ca9d57 to
c23c7bfCompareAugust 22, 2025 10:58
@markmur
markmur
enabled auto-merge (squash)
August 22, 2025 11:33
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
c23c7bf to
04ce4c4CompareAugust 26, 2025 15:44
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
04ce4c4 to
4d360b7CompareAugust 26, 2025 15:49
kieran-osgood-shopify
kieran-osgood-shopify
approved these changes
Aug 26, 2025
View reviewed changes
@kieran-osgood-shopifykieran-osgood-shopify
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as its a stylistic point - but one benefit of moving to react testing lib is we can use screen queries instead of the destructuring from render https://github.com/testing-library/dom-testing-library/releases/tag/v6.11.0
reduces the amount of changes needed to maintain / experiment with queries
@markmur
markmur
merged commit 21d38ca
into
mainAug 26, 2025

8 checks passed

@markmur
markmur
deleted the

markmur/replace-react-test-renderer

branch
August 26, 2025 16:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kieran-osgood-shopifykieran-osgood-shopifykieran-osgood-shopify approved these changes
@kiftiokiftioAwaiting requested review from kiftio

Assignees

@markmurmarkmur

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@markmur@kieran-osgood-shopify

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use @testing-library/react-native by markmur · Pull Request #277 · Shopify/checkout-sheet-kit-react-native · GitHub
Skip to content
Use @testing-library/react-native - #277
Merged
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Aug 26, 2025
Merged
Use @testing-library/react-native#277
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Conversation
@markmur
@markmurmarkmur
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
What changes are you making?
Adds @testing-library/react-native and updates the context tests.
PR Checklist
Important
Releasing a new version of the kit?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.
@markmurmarkmur
self-assigned this
Aug 20, 2025
@markmur
markmur
requested a review
from a team
as a code ownerAugust 20, 2025 11:32
@github-actions
github-actionsBot
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Coverage Report
LinesStatementsBranchesFunctions
Coverage: 100%
100% (196/196)99.04% (104/105)100% (62/62)
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
cf86f99 to
8cc1718CompareAugust 20, 2025 11:37
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
8cc1718 to
c029d80CompareAugust 20, 2025 12:37
kieran-osgood-shopify
kieran-osgood-shopify
reviewed
Aug 20, 2025
View reviewed changes
Comment threadpackage.json
Outdated

 "react-native-gesture-handler": "^2.15.0",
 "react-native-gradle-plugin": "^0.71.19",
 "react-test-renderer": "18.3.1",
 "react-test-renderer": "18.2.0",
@kieran-osgood-shopifykieran-osgood-shopifyAug 20, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @testing-library/react-native is a replacement for react-test-renderer - can we remove this dependency?
@markmurmarkmurAug 20, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@testing-library/react-native is built on top of react-test-renderer so it's still required as a peer dependency → https://github.com/callstack/react-native-testing-library/blob/main/package.json#L59
@kieran-osgood-shopifykieran-osgood-shopifyAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad I always end up on the wrong docs page for @testing-library/react-native
Useful to know - its marked as deprecated from react-native 77 / React19

Once we get to 77 and as of v14 a replacement is in an open PR here: callstack/react-native-testing-library#1705
@markmurmarkmurAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, looks like they're replacing it with a universal-test-renderer package
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
2ca9d57 to
c23c7bfCompareAugust 22, 2025 10:58
@markmur
markmur
enabled auto-merge (squash)
August 22, 2025 11:33
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
c23c7bf to
04ce4c4CompareAugust 26, 2025 15:44
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
04ce4c4 to
4d360b7CompareAugust 26, 2025 15:49
kieran-osgood-shopify
kieran-osgood-shopify
approved these changes
Aug 26, 2025
View reviewed changes
@kieran-osgood-shopifykieran-osgood-shopify
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as its a stylistic point - but one benefit of moving to react testing lib is we can use screen queries instead of the destructuring from render https://github.com/testing-library/dom-testing-library/releases/tag/v6.11.0
reduces the amount of changes needed to maintain / experiment with queries
@markmur
markmur
merged commit 21d38ca
into
mainAug 26, 2025

8 checks passed

@markmur
markmur
deleted the

markmur/replace-react-test-renderer

branch
August 26, 2025 16:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kieran-osgood-shopifykieran-osgood-shopifykieran-osgood-shopify approved these changes
@kiftiokiftioAwaiting requested review from kiftio

Assignees

@markmurmarkmur

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@markmur@kieran-osgood-shopify

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use @testing-library/react-native by markmur · Pull Request #277 · Shopify/checkout-sheet-kit-react-native · GitHub
Skip to content
Use @testing-library/react-native - #277
Merged
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Aug 26, 2025
Merged
Use @testing-library/react-native#277
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Conversation
@markmur
@markmurmarkmur
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
What changes are you making?
Adds @testing-library/react-native and updates the context tests.
PR Checklist
Important
Releasing a new version of the kit?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.
@markmurmarkmur
self-assigned this
Aug 20, 2025
@markmur
markmur
requested a review
from a team
as a code ownerAugust 20, 2025 11:32
@github-actions
github-actionsBot
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Coverage Report
LinesStatementsBranchesFunctions
Coverage: 100%
100% (196/196)99.04% (104/105)100% (62/62)
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
cf86f99 to
8cc1718CompareAugust 20, 2025 11:37
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
8cc1718 to
c029d80CompareAugust 20, 2025 12:37
kieran-osgood-shopify
kieran-osgood-shopify
reviewed
Aug 20, 2025
View reviewed changes
Comment threadpackage.json
Outdated

 "react-native-gesture-handler": "^2.15.0",
 "react-native-gradle-plugin": "^0.71.19",
 "react-test-renderer": "18.3.1",
 "react-test-renderer": "18.2.0",
@kieran-osgood-shopifykieran-osgood-shopifyAug 20, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @testing-library/react-native is a replacement for react-test-renderer - can we remove this dependency?
@markmurmarkmurAug 20, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@testing-library/react-native is built on top of react-test-renderer so it's still required as a peer dependency → https://github.com/callstack/react-native-testing-library/blob/main/package.json#L59
@kieran-osgood-shopifykieran-osgood-shopifyAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad I always end up on the wrong docs page for @testing-library/react-native
Useful to know - its marked as deprecated from react-native 77 / React19

Once we get to 77 and as of v14 a replacement is in an open PR here: callstack/react-native-testing-library#1705
@markmurmarkmurAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, looks like they're replacing it with a universal-test-renderer package
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
2ca9d57 to
c23c7bfCompareAugust 22, 2025 10:58
@markmur
markmur
enabled auto-merge (squash)
August 22, 2025 11:33
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
c23c7bf to
04ce4c4CompareAugust 26, 2025 15:44
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
04ce4c4 to
4d360b7CompareAugust 26, 2025 15:49
kieran-osgood-shopify
kieran-osgood-shopify
approved these changes
Aug 26, 2025
View reviewed changes
@kieran-osgood-shopifykieran-osgood-shopify
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as its a stylistic point - but one benefit of moving to react testing lib is we can use screen queries instead of the destructuring from render https://github.com/testing-library/dom-testing-library/releases/tag/v6.11.0
reduces the amount of changes needed to maintain / experiment with queries
@markmur
markmur
merged commit 21d38ca
into
mainAug 26, 2025

8 checks passed

@markmur
markmur
deleted the

markmur/replace-react-test-renderer

branch
August 26, 2025 16:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kieran-osgood-shopifykieran-osgood-shopifykieran-osgood-shopify approved these changes
@kiftiokiftioAwaiting requested review from kiftio

Assignees

@markmurmarkmur

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@markmur@kieran-osgood-shopify

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Use @testing-library/react-native by markmur · Pull Request #277 · Shopify/checkout-sheet-kit-react-native · GitHub
Skip to content
Use @testing-library/react-native - #277
Merged
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Aug 26, 2025
Merged
Use @testing-library/react-native#277
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Conversation
@markmur
@markmurmarkmur
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
What changes are you making?
Adds @testing-library/react-native and updates the context tests.
PR Checklist
Important
Releasing a new version of the kit?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.
@markmurmarkmur
self-assigned this
Aug 20, 2025
@markmur
markmur
requested a review
from a team
as a code ownerAugust 20, 2025 11:32
@github-actions
github-actionsBot
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Coverage Report
LinesStatementsBranchesFunctions
Coverage: 100%
100% (196/196)99.04% (104/105)100% (62/62)
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
cf86f99 to
8cc1718CompareAugust 20, 2025 11:37
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
8cc1718 to
c029d80CompareAugust 20, 2025 12:37
kieran-osgood-shopify
kieran-osgood-shopify
reviewed
Aug 20, 2025
View reviewed changes
Comment threadpackage.json
Outdated

 "react-native-gesture-handler": "^2.15.0",
 "react-native-gradle-plugin": "^0.71.19",
 "react-test-renderer": "18.3.1",
 "react-test-renderer": "18.2.0",
@kieran-osgood-shopifykieran-osgood-shopifyAug 20, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @testing-library/react-native is a replacement for react-test-renderer - can we remove this dependency?
@markmurmarkmurAug 20, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@testing-library/react-native is built on top of react-test-renderer so it's still required as a peer dependency → https://github.com/callstack/react-native-testing-library/blob/main/package.json#L59
@kieran-osgood-shopifykieran-osgood-shopifyAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad I always end up on the wrong docs page for @testing-library/react-native
Useful to know - its marked as deprecated from react-native 77 / React19

Once we get to 77 and as of v14 a replacement is in an open PR here: callstack/react-native-testing-library#1705
@markmurmarkmurAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, looks like they're replacing it with a universal-test-renderer package
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
2ca9d57 to
c23c7bfCompareAugust 22, 2025 10:58
@markmur
markmur
enabled auto-merge (squash)
August 22, 2025 11:33
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
c23c7bf to
04ce4c4CompareAugust 26, 2025 15:44
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
04ce4c4 to
4d360b7CompareAugust 26, 2025 15:49
kieran-osgood-shopify
kieran-osgood-shopify
approved these changes
Aug 26, 2025
View reviewed changes
@kieran-osgood-shopifykieran-osgood-shopify
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as its a stylistic point - but one benefit of moving to react testing lib is we can use screen queries instead of the destructuring from render https://github.com/testing-library/dom-testing-library/releases/tag/v6.11.0
reduces the amount of changes needed to maintain / experiment with queries
@markmur
markmur
merged commit 21d38ca
into
mainAug 26, 2025

8 checks passed

@markmur
markmur
deleted the

markmur/replace-react-test-renderer

branch
August 26, 2025 16:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kieran-osgood-shopifykieran-osgood-shopifykieran-osgood-shopify approved these changes
@kiftiokiftioAwaiting requested review from kiftio

Assignees

@markmurmarkmur

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@markmur@kieran-osgood-shopify

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use @testing-library/react-native by markmur · Pull Request #277 · Shopify/checkout-sheet-kit-react-native · GitHub
Skip to content
Use @testing-library/react-native - #277
Merged
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Aug 26, 2025
Merged
Use @testing-library/react-native#277
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Conversation
@markmur
@markmurmarkmur
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
What changes are you making?
Adds @testing-library/react-native and updates the context tests.
PR Checklist
Important
Releasing a new version of the kit?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.
@markmurmarkmur
self-assigned this
Aug 20, 2025
@markmur
markmur
requested a review
from a team
as a code ownerAugust 20, 2025 11:32
@github-actions
github-actionsBot
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Coverage Report
LinesStatementsBranchesFunctions
Coverage: 100%
100% (196/196)99.04% (104/105)100% (62/62)
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
cf86f99 to
8cc1718CompareAugust 20, 2025 11:37
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
8cc1718 to
c029d80CompareAugust 20, 2025 12:37
kieran-osgood-shopify
kieran-osgood-shopify
reviewed
Aug 20, 2025
View reviewed changes
Comment threadpackage.json
Outdated

 "react-native-gesture-handler": "^2.15.0",
 "react-native-gradle-plugin": "^0.71.19",
 "react-test-renderer": "18.3.1",
 "react-test-renderer": "18.2.0",
@kieran-osgood-shopifykieran-osgood-shopifyAug 20, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @testing-library/react-native is a replacement for react-test-renderer - can we remove this dependency?
@markmurmarkmurAug 20, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@testing-library/react-native is built on top of react-test-renderer so it's still required as a peer dependency → https://github.com/callstack/react-native-testing-library/blob/main/package.json#L59
@kieran-osgood-shopifykieran-osgood-shopifyAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad I always end up on the wrong docs page for @testing-library/react-native
Useful to know - its marked as deprecated from react-native 77 / React19

Once we get to 77 and as of v14 a replacement is in an open PR here: callstack/react-native-testing-library#1705
@markmurmarkmurAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, looks like they're replacing it with a universal-test-renderer package
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
2ca9d57 to
c23c7bfCompareAugust 22, 2025 10:58
@markmur
markmur
enabled auto-merge (squash)
August 22, 2025 11:33
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
c23c7bf to
04ce4c4CompareAugust 26, 2025 15:44
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
04ce4c4 to
4d360b7CompareAugust 26, 2025 15:49
kieran-osgood-shopify
kieran-osgood-shopify
approved these changes
Aug 26, 2025
View reviewed changes
@kieran-osgood-shopifykieran-osgood-shopify
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as its a stylistic point - but one benefit of moving to react testing lib is we can use screen queries instead of the destructuring from render https://github.com/testing-library/dom-testing-library/releases/tag/v6.11.0
reduces the amount of changes needed to maintain / experiment with queries
@markmur
markmur
merged commit 21d38ca
into
mainAug 26, 2025

8 checks passed

@markmur
markmur
deleted the

markmur/replace-react-test-renderer

branch
August 26, 2025 16:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kieran-osgood-shopifykieran-osgood-shopifykieran-osgood-shopify approved these changes
@kiftiokiftioAwaiting requested review from kiftio

Assignees

@markmurmarkmur

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@markmur@kieran-osgood-shopify

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Use @testing-library/react-native by markmur · Pull Request #277 · Shopify/checkout-sheet-kit-react-native · GitHub
Skip to content
Use @testing-library/react-native - #277
Merged
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Aug 26, 2025
Merged
Use @testing-library/react-native#277
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Conversation
@markmur
@markmurmarkmur
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
What changes are you making?
Adds @testing-library/react-native and updates the context tests.
PR Checklist
Important
Releasing a new version of the kit?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.
@markmurmarkmur
self-assigned this
Aug 20, 2025
@markmur
markmur
requested a review
from a team
as a code ownerAugust 20, 2025 11:32
@github-actions
github-actionsBot
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Coverage Report
LinesStatementsBranchesFunctions
Coverage: 100%
100% (196/196)99.04% (104/105)100% (62/62)
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
cf86f99 to
8cc1718CompareAugust 20, 2025 11:37
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
8cc1718 to
c029d80CompareAugust 20, 2025 12:37
kieran-osgood-shopify
kieran-osgood-shopify
reviewed
Aug 20, 2025
View reviewed changes
Comment threadpackage.json
Outdated

 "react-native-gesture-handler": "^2.15.0",
 "react-native-gradle-plugin": "^0.71.19",
 "react-test-renderer": "18.3.1",
 "react-test-renderer": "18.2.0",
@kieran-osgood-shopifykieran-osgood-shopifyAug 20, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @testing-library/react-native is a replacement for react-test-renderer - can we remove this dependency?
@markmurmarkmurAug 20, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@testing-library/react-native is built on top of react-test-renderer so it's still required as a peer dependency → https://github.com/callstack/react-native-testing-library/blob/main/package.json#L59
@kieran-osgood-shopifykieran-osgood-shopifyAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad I always end up on the wrong docs page for @testing-library/react-native
Useful to know - its marked as deprecated from react-native 77 / React19

Once we get to 77 and as of v14 a replacement is in an open PR here: callstack/react-native-testing-library#1705
@markmurmarkmurAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, looks like they're replacing it with a universal-test-renderer package
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
2ca9d57 to
c23c7bfCompareAugust 22, 2025 10:58
@markmur
markmur
enabled auto-merge (squash)
August 22, 2025 11:33
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
c23c7bf to
04ce4c4CompareAugust 26, 2025 15:44
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
04ce4c4 to
4d360b7CompareAugust 26, 2025 15:49
kieran-osgood-shopify
kieran-osgood-shopify
approved these changes
Aug 26, 2025
View reviewed changes
@kieran-osgood-shopifykieran-osgood-shopify
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as its a stylistic point - but one benefit of moving to react testing lib is we can use screen queries instead of the destructuring from render https://github.com/testing-library/dom-testing-library/releases/tag/v6.11.0
reduces the amount of changes needed to maintain / experiment with queries
@markmur
markmur
merged commit 21d38ca
into
mainAug 26, 2025

8 checks passed

@markmur
markmur
deleted the

markmur/replace-react-test-renderer

branch
August 26, 2025 16:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kieran-osgood-shopifykieran-osgood-shopifykieran-osgood-shopify approved these changes
@kiftiokiftioAwaiting requested review from kiftio

Assignees

@markmurmarkmur

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@markmur@kieran-osgood-shopify

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Use @testing-library/react-native by markmur · Pull Request #277 · Shopify/checkout-sheet-kit-react-native · GitHub
Skip to content
Use @testing-library/react-native - #277
Merged
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Aug 26, 2025
Merged
Use @testing-library/react-native#277
markmur merged 1 commit into
mainfrom 
markmur/replace-react-test-renderer
Conversation
@markmur
@markmurmarkmur
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
What changes are you making?
Adds @testing-library/react-native and updates the context tests.
PR Checklist
Important
Releasing a new version of the kit?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.
@markmurmarkmur
self-assigned this
Aug 20, 2025
@markmur
markmur
requested a review
from a team
as a code ownerAugust 20, 2025 11:32
@github-actions
github-actionsBot
commented
Aug 20, 2025•

edited

Loading

Copy link


Copy Markdown

Coverage Report
LinesStatementsBranchesFunctions
Coverage: 100%
100% (196/196)99.04% (104/105)100% (62/62)
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
cf86f99 to
8cc1718CompareAugust 20, 2025 11:37
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
8cc1718 to
c029d80CompareAugust 20, 2025 12:37
kieran-osgood-shopify
kieran-osgood-shopify
reviewed
Aug 20, 2025
View reviewed changes
Comment threadpackage.json
Outdated

 "react-native-gesture-handler": "^2.15.0",
 "react-native-gradle-plugin": "^0.71.19",
 "react-test-renderer": "18.3.1",
 "react-test-renderer": "18.2.0",
@kieran-osgood-shopifykieran-osgood-shopifyAug 20, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @testing-library/react-native is a replacement for react-test-renderer - can we remove this dependency?
@markmurmarkmurAug 20, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@testing-library/react-native is built on top of react-test-renderer so it's still required as a peer dependency → https://github.com/callstack/react-native-testing-library/blob/main/package.json#L59
@kieran-osgood-shopifykieran-osgood-shopifyAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad I always end up on the wrong docs page for @testing-library/react-native
Useful to know - its marked as deprecated from react-native 77 / React19

Once we get to 77 and as of v14 a replacement is in an open PR here: callstack/react-native-testing-library#1705
@markmurmarkmurAug 21, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, looks like they're replacing it with a universal-test-renderer package
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
2 times, most recently
from
2ca9d57 to
c23c7bfCompareAugust 22, 2025 10:58
@markmur
markmur
enabled auto-merge (squash)
August 22, 2025 11:33
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
c23c7bf to
04ce4c4CompareAugust 26, 2025 15:44
@markmur
markmurforce-pushed
the
markmur/replace-react-test-renderer
branch
from
04ce4c4 to
4d360b7CompareAugust 26, 2025 15:49
kieran-osgood-shopify
kieran-osgood-shopify
approved these changes
Aug 26, 2025
View reviewed changes
@kieran-osgood-shopifykieran-osgood-shopify
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as its a stylistic point - but one benefit of moving to react testing lib is we can use screen queries instead of the destructuring from render https://github.com/testing-library/dom-testing-library/releases/tag/v6.11.0
reduces the amount of changes needed to maintain / experiment with queries
@markmur
markmur
merged commit 21d38ca
into
mainAug 26, 2025

8 checks passed

@markmur
markmur
deleted the

markmur/replace-react-test-renderer

branch
August 26, 2025 16:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kieran-osgood-shopifykieran-osgood-shopifykieran-osgood-shopify approved these changes
@kiftiokiftioAwaiting requested review from kiftio

Assignees

@markmurmarkmur

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@markmur@kieran-osgood-shopify