Uh oh!
There was an error while loading. Please reload this page.
WIP - #2017
Open
charlespwd wants to merge 6 commits into
Open
Conversation
charlespwdforce-pushed
the
cp-one-parser
branch
from
December 2, 2025 14:38
cf8f143 to
07531a7Comparecharlespwdforce-pushed
the
cp-one-parser
branch
from
December 2, 2025 14:44
07531a7 to
c12fc1bComparecharlespwd
marked this pull request as ready for review
December 2, 2025 15:28
karreiro
approved these changes
Dec 2, 2025
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this PR, @charlespwd! Great stuff! I've left some comments that may be applied in follow-up PRs.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
karreiro
approved these changes
Dec 3, 2025
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the changes, @charlespwd!
| * As tag argument `{% render 'snip', enabled: a or b %}` | ||
| * As conditional tag argument `{% if cond %}` (extending previous behaviour) | ||
| * (TODO) Add support for subexpression prioritization and associativity | ||
| * In ascending order of priority: |
ContributorAuthor
There was a problem hiding this comment.
Deep pull :D It's not in scope (yet?), but, unlike last time, we wouldn't be held back by lax anymore and the system would leave space for a UnaryExpression node with an operator and an expression.
charlespwdforce-pushed
the
cp-one-parser
branch
from
January 12, 2026 16:44
d22ead1 to
3a675a4Comparecharlespwdforce-pushed
the
cp-one-parser
branch
2 times, most recently
from
January 12, 2026 18:52
cf8fdf6 to
d0ccab5Comparecharlespwdforce-pushed
the
cp-one-parser
branch
from
January 14, 2026 14:55
d0ccab5 to
f4a5454Comparecharlespwdforce-pushed
the
cp-one-parser
branch
from
January 26, 2026 19:25
9907965 to
f4a5454CompareThis branch gates lax-mode-only specs behind lax_parsing feature: - shopify_production_recordings: 22 specs - liquid_ruby: 16 specs - basics: error regex updated Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
graygilmore
removed their request for review
March 23, 2026 16:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers, please note base branch to PR.
In this PR
Environment.error_modelax_parse,strict_parse+:warnerror modestrict2_parsetoparse_markupwarningssystem