Skip to content

WIP2 - #2020

Draft
charlespwd wants to merge 17 commits into
cp-one-parserfrom
cp-expression-refactor
Draft

WIP2#2020
charlespwd wants to merge 17 commits into
cp-one-parserfrom
cp-expression-refactor

Conversation

@charlespwd

@charlespwdcharlespwd commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Architectural changes

  • parse_expression and safe_parse_expression have been removed from Tag and ParseContext
  • Parser methods now produce AST nodes instead of strings
    • Parser#expression produces a value,
    • Parser#string produces a string,
    • etc.

Breaking changes

  • Parser#expression is renamed to Parser#expression_string
  • safe_parse_expression methods are replaced by Parser#expression
  • parse_expression methods are replaced by Parser#unsafe_parse_expression

@charlespwd
charlespwdforce-pushed the cp-expression-refactor branch from 9e95ad0 to 5e3d8f4CompareDecember 3, 2025 17:46
@charlespwd
charlespwdforce-pushed the cp-expression-refactor branch from 5e3d8f4 to 34101f9CompareJanuary 12, 2026 16:56
@charlespwd
charlespwdforce-pushed the cp-one-parser branch 3 times, most recently from d0ccab5 to f4a5454CompareJanuary 14, 2026 14:55
@charlespwd
charlespwdforce-pushed the cp-expression-refactor branch from 34101f9 to 806c613CompareJanuary 14, 2026 14:57
@charlespwd
charlespwdforce-pushed the cp-expression-refactor branch from 806c613 to 1cb61d0CompareJanuary 26, 2026 16:06
charlespwdand others added 17 commits January 26, 2026 16:52
@charlespwd
Remove warnings system
8515843
@charlespwd
Move safe_parse_expression into Parser.expression_node
cf3d845
- Make `Parser` accept the expression cache
- Remove `safe_parse_expression` from `ParseContext`
- Replace all usage of `safe_parse_expression` with `parser.expression_node`
@charlespwd
Move parse_expression to Parser.unsafe_parse_expression
7d0bdd1
- Add Parser#string
- Add Parser#unsafe_parse_expression
- Add private Parser#parse_expression
- Remove ParseContext.parse_expression
- Remove Tag.parse_expression
- Condition.parse_expression now takes a parser as argument
@charlespwd
Rename Parser#expression -> Parser#expression_string
6b78291
@charlespwd
Rename Parser#argument -> argument_string
6cfcd6c
@charlespwd
Rename Parser#expression_node -> Parser#expression
c9ae128
@charlespwd
Remove Expression#safe_parse
85d73e4
@charlespwd
Extract Parser#string out of Expression.parse
2a86852
@charlespwd
Extract Parser#number parse out of Expression.parse
e1e0129
@charlespwd
Simplify parse_number
288c4ea
We don't need all the multi-dot logic in a world where number comes
out of the Lexer.
@charlespwd
Replace RangeLookup.parse with RangeLookup.create
af774eb
@charlespwd
Move VariableLookup parsing logic to .parse instead of initializer
8efcf7d
Goal is to get rid of it entirely, but baby steps.
@charlespwd
Extract Parser#variable_lookup out of Expression.parse
8b04c52
@charlespwd
Extract Parser#range_lookup out of Expression.parse
dff829e
@charlespwd
Replace Context[]'s Expression.parse with Parser#expression
18f1e8a
@charlespwd@claude
fix(case): use Condition.parse_expression for empty/blank handling
1b420ab
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@charlespwd@claude
style: fix rubocop offenses
6f03452
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@charlespwd
charlespwdforce-pushed the cp-expression-refactor branch from 1cb61d0 to 6f03452CompareJanuary 27, 2026 15:00
@graygilmore
graygilmore removed their request for review March 23, 2026 16:00
@graygilmore
graygilmore removed the request for review from karreiroMarch 23, 2026 16:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

#gsd:48203

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@charlespwd