Skip to content

Improve test stability - #4002

Open
soutaro wants to merge 2 commits into
mainfrom
fix-test
Open

Improve test stability#4002
soutaro wants to merge 2 commits into
mainfrom
fix-test

Conversation

@soutaro

@soutarosoutaro commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

This PR is to make some tests more stable.

  • Replaced a fixed 10-second delay in workspace.test.ts with the new retry utility, allowing assertions to be retried for up to 30 seconds, improving reliability in the presence of asynchronous file system events.
  • Increased test timeouts in testController.test.ts and workspace.test.ts to 30 and 60 seconds respectively, ensuring tests have sufficient time to complete under slow conditions.

@soutarosoutaro added chore Chore task labels Mar 9, 2026
@soutarosoutaro changed the title Wait for 30secsImprove test stabilityMar 9, 2026
@soutaro
soutaro marked this pull request as ready for review March 9, 2026 06:11
@soutaro
soutaro requested a review from a team as a code ownerMarch 9, 2026 06:11
Comment threadvscode/src/test/suite/helpers.ts Outdated
@soutaro

Copy link
Copy Markdown
ContributorAuthor

Another test is failing...

 1 failing
1) Launch integrations
with launcher mode enabled:
Error: Timeout of 120000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (d:\a\ruby-lsp\ruby-lsp\vscode\out\test\suite\launch.test.js)
at listOnTimeout (node:internal/timers:588:17)
at process.processTimers (node:internal/timers:523:7)
Error: 1 tests failed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

choreChore task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@soutaro@st0012