Uh oh!
There was an error while loading. Please reload this page.
Migrate rename to use Rubydex - #4033
Merged
Merged
Conversation
vinistockforce-pushed
the
vs_migrate_rename
branch
from
March 26, 2026 21:09
820402d to
46c23bcCompare19 tasks
vinistockforce-pushed
the
rubydex_adoption_feature_branch
branch
from
March 30, 2026 14:02
4a0f2a1 to
37cddf3Comparevinistockforce-pushed
the
vs_migrate_rename
branch
from
March 30, 2026 14:03
46c23bc to
4bed073Comparealexcrocha
approved these changes
Mar 31, 2026
Uh oh!
There was an error while loading. Please reload this page.
vinistockforce-pushed
the
vs_migrate_rename
branch
from
March 31, 2026 20:34
4bed073 to
5da44dfCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate rename to use Rubydex. We currently only support constants, but we can easily expand to global, class and instance variables once we finish adding indexing for them.
Implementation
The main changes are actually simplifications. We don't need the
ReferenceFinderbecause Rubydex tracks references. We can just access it directly, which makes the implementation more straight forward.Automated Tests
The rename tests were pretty messy and difficult to write. I refactored the tests a bit and added a couple more scenarios.