Uh oh!
There was an error while loading. Please reload this page.
Migrate test discovery to use Rubydex - #4064
Merged
vinistock merged 1 commit intoApr 28, 2026
Merged
Conversation
vinistock
commented
Apr 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
19 tasks
vinistockforce-pushed
the
rubydex_adoption_feature_branch
branch
from
April 21, 2026 15:02
9bf9d19 to
9ca38dbComparevinistockforce-pushed
the
vs_migrate_test_discovery
branch
2 times, most recently
from
April 21, 2026 15:08
94a4778 to
0966f07Comparevinistockforce-pushed
the
rubydex_adoption_feature_branch
branch
from
April 28, 2026 14:34
328b3db to
d1435acComparevinistockforce-pushed
the
vs_migrate_test_discovery
branch
from
April 28, 2026 14:35
0966f07 to
9a7f7e4CompareMorriar
approved these changes
Apr 28, 2026
Uh oh!
There was an error while loading. Please reload this page.
vinistock added a commit
that referenced
this pull request
May 7, 2026
vinistock added a commit
that referenced
this pull request
Jun 11, 2026
vinistock added a commit
that referenced
this pull request
Jun 15, 2026
vinistock added a commit
that referenced
this pull request
Jul 2, 2026
vinistock added a commit
that referenced
this pull request
Jul 3, 2026
vinistock added a commit
that referenced
this pull request
Jul 24, 2026
vinistock added a commit
that referenced
this pull request
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate test discovery to use Rubydex.
Implementation
Since Rubydex handles incremental changes immediately on edits, we no longer need the complicated lazy indexing case. We can trust the graph to be up to date.
Automated Tests
There are still some incremental handling weirdness, so I made small adjustments to the tests to avoid it and unblock this migration.