Uh oh!
There was an error while loading. Please reload this page.
Migrate document to use YARP - #863
Conversation
|
| end | ||
| def test_parsed_returns_false_when_parsing_fails | ||
| def test_parsed_returns_true_when_parsing_fails |
There was a problem hiding this comment.
Since YARP is able to parse code with syntax errors, I've changed the behaviour here.
There was a problem hiding this comment.
We can get rid of this one when removing parsed?.
2e92719 to
4f28646Compare| @uri = T.let(uri, URI::Generic) | ||
| @unparsed_edits = T.let([], T::Array[EditShape]) | ||
| @syntax_error = T.let(false, T::Boolean) | ||
| @tree = T.let(SyntaxTree.parse(@source), T.nilable(SyntaxTree::Node)) |
There was a problem hiding this comment.
Since we are introducing @parse_result, I eliminated @tree, to reduce the number of state variables needed.
|
2 similar comments
|
|
| sig { returns(T::Boolean) } | ||
| def parsed? | ||
| !@tree.nil? | ||
| !@parse_result.value.nil? |
There was a problem hiding this comment.
@vinistock you had removed this method but I re-added (since some other classes still rely on it) but changed the behaviour. We can re-visit later confirm if this is the right approach, I'm just aiming to get the tests green first.
4f28646 to
16281e7Compare |
1 similar comment
|
Uh oh!
There was an error while loading. Please reload this page.
ccc785a to
7ccd851Compare |
7ccd851 to
ccc785aCompare |
1 similar comment
|
Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com>
6db6970 to
af350b4Compare |
1 similar comment
|
| sig { returns(T::Boolean) } | ||
| def parsed? | ||
| !@tree.nil? | ||
| !!@parse_result.value |
There was a problem hiding this comment.
Let's get rid of this method, there's no value in keeping it anymore. We parse the document the moment it's instantiated and because YARP always succeeds in returning an AST, this method will always return true no matter what.
| end | ||
| def test_parsed_returns_false_when_parsing_fails | ||
| def test_parsed_returns_true_when_parsing_fails |
There was a problem hiding this comment.
We can get rid of this one when removing parsed?.
| end | ||
| def test_parsed_returns_true_when_parsed_successfully | ||
| # We are just ensuring that no error is raised |
There was a problem hiding this comment.
I think we can remove this test. If instantiating a new document with a valid Ruby string is failing, then pretty much every other test will also fail.
|
Cherry-pick of @vinistock's PR from another branch. I then updated the tests.
bin/test test/document_test.rbis passing