Skip to content

Use released version of YARP gem - #865

Merged
andyw8 merged 3 commits into
yarpfrom
andyw8/use-released-yarp
Aug 9, 2023
Merged

Use released version of YARP gem#865
andyw8 merged 3 commits into
yarpfrom
andyw8/use-released-yarp

Conversation

@andyw8

@andyw8andyw8 commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

(PR is against yarp branch, not expected to be passing yet).

@andyw8
andyw8 changed the base branch from main to yarpAugust 9, 2023 14:57
@andyw8
andyw8 marked this pull request as ready for review August 9, 2023 14:58
@andyw8
andyw8 requested a review from a team as a code ownerAugust 9, 2023 14:58
@andyw8andyw8 mentioned this pull request Aug 9, 2023
29 tasks
@andyw8

Copy link
Copy Markdown
ContributorAuthor

Updated to also have yarp in the .gemspec.

@vinistock

Copy link
Copy Markdown
Member

Good point, we don't need it in the Gemfile, just in the gemspec.

@andyw8
andyw8 merged commit ddba9ca into yarpAug 9, 2023
@andyw8
andyw8 deleted the andyw8/use-released-yarp branch August 9, 2023 15:06
@github-actions

github-actionsBot commented Aug 9, 2023

Copy link
Copy Markdown
Contributor
Benchmark results in seconds (slowest at top)
textDocument/completion average: 0.267958 std_dev: 0.004969
textDocument/diagnostic average: 0.038847 std_dev: 0.010171
textDocument/definition average: 0.005467 std_dev: 0.00294
textDocument/selectionRange average: 0.004012 std_dev: 0.000465
textDocument/documentHighlight average: 0.002461 std_dev: 0.00018
textDocument/codeLens average: 0.002445 std_dev: 0.000171
textDocument/documentLink average: 0.002428 std_dev: 0.000182
textDocument/semanticTokens/full average: 0.002391 std_dev: 0.000265
textDocument/documentSymbol average: 0.002387 std_dev: 0.000144
textDocument/foldingRange average: 0.002224 std_dev: 0.000167
textDocument/semanticTokens/range average: 0.001594 std_dev: 6.3e-05
codeAction/resolve average: 0.001363 std_dev: 9.7e-05
textDocument/inlayHint average: 0.001355 std_dev: 9.3e-05
textDocument/hover average: 0.001326 std_dev: 0.000104
textDocument/onTypeFormatting average: 0.000813 std_dev: 8.1e-05
textDocument/formatting average: 0.000801 std_dev: 0.000291
textDocument/codeAction average: 0.00079 std_dev: 7.3e-05
================================================================================
Comparison with main branch:
textDocument/semanticTokens/full unchanged
textDocument/semanticTokens/range unchanged
textDocument/documentSymbol unchanged
textDocument/foldingRange unchanged
textDocument/formatting unchanged
textDocument/diagnostic unchanged
textDocument/documentLink unchanged
textDocument/inlayHint unchanged
textDocument/selectionRange unchanged
textDocument/documentHighlight unchanged
textDocument/hover unchanged
textDocument/codeAction unchanged
textDocument/onTypeFormatting unchanged
codeAction/resolve unchanged
textDocument/completion unchanged
textDocument/codeLens unchanged
textDocument/definition unchanged
================================================================================
Missing benchmarks:
RubyLsp::Requests::ShowSyntaxTree

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@andyw8@vinistock@Morriar