Uh oh!
There was an error while loading. Please reload this page.
Migrate inlay hints to yarp - #871
Conversation
|
e940965 to
656c461Compare| exception = node.exception | ||
| return unless exception.nil? || exception.exceptions.nil? | ||
| sig { params(node: T.nilable(YARP::Node)).void } | ||
| def on_node(node) |
There was a problem hiding this comment.
Since YARP doesn't support visit_rescue, I'm not sure if there's a better way to do this?
There was a problem hiding this comment.
Since YARP doesn't support visit_rescue
Is there a reason for this?
There was a problem hiding this comment.
@vinistock reading https://github.com/ruby/yarp/blob/47fe0daddf2a2eab765e6b3ebff744d3fa614786/lib/yarp.rb#L152-L155, it sounds like we would need to implement a number of visit_ methods, is that the approach we want to take?
|
1 similar comment
|
vinistock
left a comment
There was a problem hiding this comment.
I think it's called visit_rescue_node. Also, this had already been migrated, I have the commit 9e19894 Migrate inlay hint in my original vs/migrate_to_yarp branch.
656c461 to
7cbff4fCompare7cbff4f to
daa79f9Comparedaa79f9 to
54f2472Compareandyw8
commented
Aug 15, 2023
Updated to use Vini's version, I had missed checking what was already done. |
|
2 similar comments
|
|
Co-authored with @bitwise-aiden
Partially addresses #449
bin/test test/requests/inlay_hints_expectations_test.rbpasses