Uh oh!
There was an error while loading. Please reload this page.
Migrate path completion to YARP - #873
Merged
Merged
Conversation
29 tasks
Contributor
|
andyw8force-pushed
the
andyw8/migrate-path-completion-to-yarp
branch
2 times, most recently
from
August 14, 2023 20:52
697098f to
a49bdc1CompareContributor
|
1 similar comment
Contributor
|
andyw8
commented
Aug 15, 2023
| end_position = { | ||
| line: 0, | ||
| character: document.source.rindex('"'), | ||
| character: document.source.rindex('o') |
Contributor
|
andyw8force-pushed
the
andyw8/migrate-path-completion-to-yarp
branch
2 times, most recently
from
August 18, 2023 20:33
31aaeb3 to
d5460d2Compareandyw8
marked this pull request as ready for review
August 18, 2023 20:35
Morriar
reviewed
Aug 21, 2023
| def on_tstring_content(node) | ||
| @tree.search(node.value).sort.each do |path| | ||
| sig { params(node: YARP::StringNode).void } | ||
| def on_string_node(node) |
Contributor
There was a problem hiding this comment.
Suggested change
| defon_string_node(node) | |
| defon_string(node) |
andyw8force-pushed
the
andyw8/migrate-path-completion-to-yarp
branch
from
August 21, 2023 13:50
d5460d2 to
2fa7421CompareMorriar
approved these changes
Aug 21, 2023
vinistock
approved these changes
Aug 21, 2023
| end_position = { | ||
| line: 0, | ||
| character: document.source.rindex('"'), | ||
| character: T.must(document.source.rindex('"')) - 1, |
Member
There was a problem hiding this comment.
These off by one errors need to be fixed in YARP. I wonder how hard it would be to help them get this done, so that we can stop altering our tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #449
Co-authored with @bitwise-aiden, cherry-picked from @vinistock's WIP version, then updated.
bin/test test/requests/path_completion_test.rbis passing