Uh oh!
There was an error while loading. Please reload this page.
Migrate Selection Ranges to YARP - #895
Merged
Merged
Conversation
Contributor
|
1 similar comment
Contributor
|
Contributor
|
andyw8force-pushed
the
andyw8/migrate-selection-ranges-to-yarp
branch
2 times, most recently
from
August 18, 2023 14:52
823821b to
61031a1Compare29 tasks
andyw8force-pushed
the
andyw8/migrate-selection-ranges-to-yarp
branch
2 times, most recently
from
August 30, 2023 17:10
49439ce to
0406ca7Compareandyw8
commented
Aug 30, 2023
| }, | ||
| "end": { | ||
| "line": 0, | ||
| "character": 6 |
ContributorAuthor
There was a problem hiding this comment.
end columns are off by 1 due to a YARP issue which is being addressed separately.
andyw8force-pushed
the
andyw8/migrate-selection-ranges-to-yarp
branch
from
August 30, 2023 17:23
0406ca7 to
9cd1df7Compareandyw8
commented
Aug 30, 2023
| ).returns(Support::SelectionRange) | ||
| end | ||
| def create_selection_range(location, parent = nil) | ||
| def create_selection_range(location, parent) |
ContributorAuthor
There was a problem hiding this comment.
I removed the unnecessary nil default for parent since we always pass something.
andyw8force-pushed
the
andyw8/migrate-selection-ranges-to-yarp
branch
from
August 30, 2023 17:30
9cd1df7 to
1efa776Compareandyw8
commented
Aug 30, 2023
| "character": 0 | ||
| } | ||
| }, | ||
| "parent": { |
ContributorAuthor
There was a problem hiding this comment.
If it helps for reviewing, I can add a note to explain each 'substantial' change in the expectations.
vinistock
approved these changes
Aug 30, 2023
Uh oh!
There was an error while loading. Please reload this page.
andyw8force-pushed
the
andyw8/migrate-selection-ranges-to-yarp
branch
from
August 30, 2023 18:01
3a5d6eb to
8be1661Comparevinistock pushed a commit
that referenced
this pull request
Feb 28, 2024
Avoid adding yjit flag since ruby 3.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #449
Paired on with @vinistock for parts.
Note: Some fixtures intentionally changed to be closer to how YARP represents the code.