Temporarily disable tests for in-progress YARP migrations - #920
Merged
andyw8 merged 4 commits intoAug 23, 2023
Merged
Conversation
andyw8
force-pushed
the
andyw8/temporily-disable-tests-for-in-progress-yarp-migrations
branch
from
August 22, 2023 18:15
671a1b2 to
c40a1ed
Compare
andyw8
commented
Aug 22, 2023
| (6...6) | ||
| ), | ||
| 0, | ||
| \"foo\" |
Contributor
Author
There was a problem hiding this comment.
To ensure the linting step passes.
bitwise-aiden
approved these changes
Aug 22, 2023
Contributor
|
Contributor
Author
|
I see there's a Windows failure, will fix that first. |
andyw8
force-pushed
the
andyw8/temporily-disable-tests-for-in-progress-yarp-migrations
branch
from
August 23, 2023 13:47
2f53427 to
c21b8b1
Compare
andyw8
force-pushed
the
andyw8/temporily-disable-tests-for-in-progress-yarp-migrations
branch
from
August 23, 2023 14:01
3b1aef5 to
af7f47b
Compare
Contributor
Author
|
I can't figure out what's causing those 2 Windows failures, seems there is something about the line endings of two of the fixtures. I've disabled the windows check for now. |
andyw8
deleted the
andyw8/temporily-disable-tests-for-in-progress-yarp-migrations
branch
August 23, 2023 14:10
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to verify that the requests migrated so far remain green, and make it easier to spot regressions when updating the
yarpbranch against themainbranch.