Skip to content

Temporarily disable tests for in-progress YARP migrations - #920

Merged
andyw8 merged 4 commits into
yarpfrom
andyw8/temporily-disable-tests-for-in-progress-yarp-migrations
Aug 23, 2023
Merged

Temporarily disable tests for in-progress YARP migrations#920
andyw8 merged 4 commits into
yarpfrom
andyw8/temporily-disable-tests-for-in-progress-yarp-migrations

Conversation

@andyw8

@andyw8 andyw8 commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

This will allow us to verify that the requests migrated so far remain green, and make it easier to spot regressions when updating the yarp branch against the main branch.

@andyw8
andyw8 force-pushed the andyw8/temporily-disable-tests-for-in-progress-yarp-migrations branch from 671a1b2 to c40a1ed Compare August 22, 2023 18:15
(6...6)
),
0,
\"foo\"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure the linting step passes.

@andyw8
andyw8 marked this pull request as ready for review August 22, 2023 18:19
@andyw8
andyw8 requested a review from a team as a code owner August 22, 2023 18:19
@github-actions

github-actions Bot commented Aug 22, 2023

Copy link
Copy Markdown
Contributor
Benchmark results in seconds (slowest at top)

          textDocument/completion average: 0.300952 std_dev: 0.010604
          textDocument/diagnostic average: 0.052552 std_dev: 0.012157
          textDocument/definition average: 0.006047 std_dev: 0.003303
   textDocument/documentHighlight average: 0.001859 std_dev: 0.000406
               textDocument/hover average: 0.001499 std_dev: 0.000301
               codeAction/resolve average: 0.001491 std_dev: 0.000285
           textDocument/inlayHint average: 0.001352 std_dev: 0.000252
 textDocument/semanticTokens/full average: 0.001127 std_dev: 0.000287
        textDocument/documentLink average: 0.001115 std_dev: 0.000213
            textDocument/codeLens average: 0.001114 std_dev: 0.000308
      textDocument/documentSymbol average: 0.001086 std_dev: 0.000335
      textDocument/selectionRange average: 0.001058 std_dev: 0.000266
textDocument/semanticTokens/range average: 0.001054 std_dev: 0.000316
    textDocument/onTypeFormatting average: 0.001045 std_dev: 0.000204
          textDocument/codeAction average: 0.001005 std_dev: 0.000189
        textDocument/foldingRange average: 0.001004 std_dev: 0.000221
          textDocument/formatting average: 0.000998 std_dev: 0.000306


================================================================================
Comparison with main branch:

 textDocument/semanticTokens/full faster by 59.262 %
textDocument/semanticTokens/range faster by 39.522 %
      textDocument/documentSymbol faster by 60.418 %
        textDocument/foldingRange faster by 61.444 %
          textDocument/formatting unchanged
          textDocument/diagnostic unchanged
        textDocument/documentLink faster by 58.573 %
           textDocument/inlayHint unchanged
      textDocument/selectionRange faster by 76.334 %
   textDocument/documentHighlight faster by 31.597 %
               textDocument/hover unchanged
          textDocument/codeAction unchanged
    textDocument/onTypeFormatting unchanged
               codeAction/resolve unchanged
          textDocument/completion slower by 8.096 %
            textDocument/codeLens faster by 64.841 %
          textDocument/definition unchanged


At least one benchmark is slower than the main branch.


================================================================================
Missing benchmarks:

RubyLsp::Requests::ShowSyntaxTree

@andyw8

andyw8 commented Aug 22, 2023

Copy link
Copy Markdown
Contributor Author

I see there's a Windows failure, will fix that first.

@andyw8
andyw8 force-pushed the andyw8/temporily-disable-tests-for-in-progress-yarp-migrations branch from 2f53427 to c21b8b1 Compare August 23, 2023 13:47
@andyw8
andyw8 force-pushed the andyw8/temporily-disable-tests-for-in-progress-yarp-migrations branch from 3b1aef5 to af7f47b Compare August 23, 2023 14:01
@andyw8

andyw8 commented Aug 23, 2023

Copy link
Copy Markdown
Contributor Author

I can't figure out what's causing those 2 Windows failures, seems there is something about the line endings of two of the fixtures. I've disabled the windows check for now.

@andyw8
andyw8 merged commit d6a7468 into yarp Aug 23, 2023
@andyw8
andyw8 deleted the andyw8/temporily-disable-tests-for-in-progress-yarp-migrations branch August 23, 2023 14:10
@vinistock vinistock mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants