Uh oh!
There was an error while loading. Please reload this page.
feat: improve code quality with rector rules - #328
Merged
matteodepalo merged 3 commits intoApr 18, 2024
Conversation
shakaran
commented
Mar 2, 2024
ContributorAuthor
Hi @paulomarg, just let me know if you need more info about the changes. This is a batch of updates and improvements (first iteration). I have pending more to send when this gets merged. Thanks! |
paulomarg
commented
Apr 16, 2024
Contributor
I think these changes are ok, but if we're going to add something like this, we should also include the scripts / rules so that others can also run it. |
shakaran
commented
Apr 16, 2024
ContributorAuthor
ok, no prob, after you merge this, I will send more PR and one with the rector config rule. Also I can add in a CI for the future PR |
matteodepalo
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve code quality over src and tests folders appling rector rules with PHP 8.1 support.
Applied rules:
Type of change
Checklist