Uh oh!
There was an error while loading. Please reload this page.
extend:webhook-deliveries - #364
Conversation
lizkenyon
left a comment
There was a problem hiding this comment.
Hi there 👋
Thanks for your contribution!
We will need to keep the functionality were the webhook subscription is either created or updated, and we will need to use the getMutationName so that we call the correct mutation based on the type of subscription we are creating (pubsub, http ect).
We should also update the tests to include these new parameters.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
admirsaheta
commented
Sep 11, 2024
Should be good now, also updated php-docs @lizkenyon |
lizkenyon
commented
Sep 11, 2024
@admirsaheta You will need to update the tests for the register method now that we have changed the request to create the subscriptions. |
admirsaheta
commented
Sep 12, 2024
Not really well-versed with tests, would appreciate co-authoring here. :) |
| $metafieldNamespacesQuery = !empty($metafieldNamespaces) ? 'metafieldNamespaces: [' . implode(',', $metafieldNamespaces) . ']' : ''; | ||
| // Assemble the webhook subscription arguments | ||
| $webhookSubscriptionArgs = $this->queryEndpoint($callbackAddress); |
There was a problem hiding this comment.
We need to use this method to properly build the callback URL, for each of the webhook cases Pubsub, HTTP, eventbridge.
lizkenyon
commented
Sep 25, 2024
To run the tests you can run |
DevMahix
commented
Oct 2, 2024
"I have signed the CLA!" |
WHY are these changes introduced?
Fixes#362
This pull request addresses the lack of support for specifying fields and metafieldNamespaces in webhook registrations.
The feature aligns with the Ruby implementation by allowing more granular control over which fields and metafields are included
in the webhook payload.
WHAT is this pull request doing?
fieldsandmetafieldNamespacesin thebuildRegisterQuerymethod of theRegistryclass.buildRegisterQuerymethod to construct GraphQL mutations with these new parameters.Type of change
Checklist