Skip to content

Add shop validation - #1443

Merged
gonzaloriestra merged 1 commit into
mainfrom
river/use-jwt-dest-for-token-exchange
Apr 16, 2026
Merged

Add shop validation#1443
gonzaloriestra merged 1 commit into
mainfrom
river/use-jwt-dest-for-token-exchange

Conversation

@gonzaloriestra

@gonzaloriestragonzaloriestra commented Apr 9, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

https://docs.google.com/document/d/1c0iXhKBpm-yhvff0iSgq1XwBSPL39fTBVajIJ3svaxU/edit?usp=sharing

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@gonzaloriestra
gonzaloriestraforce-pushed the river/use-jwt-dest-for-token-exchange branch from aaf2cc7 to 7992177CompareApril 9, 2026 11:38
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review April 9, 2026 11:59
@lizkenyon
lizkenyon requested a review from zzooeeyyApril 9, 2026 14:18
lizkenyon
lizkenyon reviewed Apr 9, 2026
View reviewed changes
Comment threadlib/shopify_api/auth/token_exchange.rb
Comment threadlib/shopify_api/utils/shop_validator.rb Outdated
Comment threadlib/shopify_api/utils/shop_validator.rb Outdated
zzooeeyy
zzooeeyy reviewed Apr 9, 2026
View reviewed changes
Comment threadlib/shopify_api/utils/shop_validator.rb Outdated

module ShopifyAPI
module Utils
class ShopValidator

@zzooeeyyzzooeeyyApr 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a similar sanitize method from shopify_app gem, I wonder if the logic can be extracted so we don't have to maintain 2 packages for validating Shopify URLS

@gonzaloriestragonzaloriestraApr 14, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finally copied the code from there. Once we release a new version, we could use it from shopify_app, as it's already using shopify-api-ruby. Makes sense?

Comment threadlib/shopify_api/auth/token_exchange.rb
Comment threadlib/shopify_api/utils/shop_validator.rb Outdated
@gonzaloriestra
gonzaloriestraforce-pushed the river/use-jwt-dest-for-token-exchange branch from 7992177 to 66cb7f4CompareApril 14, 2026 12:46
@gonzaloriestra
gonzaloriestraforce-pushed the river/use-jwt-dest-for-token-exchange branch from 66cb7f4 to d51f23aCompareApril 14, 2026 12:57
lizkenyon
lizkenyon reviewed Apr 14, 2026
View reviewed changes
Comment threadlib/shopify_api/auth/token_exchange.rb
@gonzaloriestra
gonzaloriestraforce-pushed the river/use-jwt-dest-for-token-exchange branch from d51f23a to 89b2da5CompareApril 15, 2026 10:25
@gonzaloriestra
gonzaloriestraforce-pushed the river/use-jwt-dest-for-token-exchange branch from 89b2da5 to 3e01209CompareApril 15, 2026 11:09
lizkenyon
lizkenyon approved these changes Apr 15, 2026
View reviewed changes

@lizkenyonlizkenyon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for this! ⭐

@gonzaloriestra
gonzaloriestra merged commit eda8616 into mainApr 16, 2026
7 checks passed
@gonzaloriestra
gonzaloriestra deleted the river/use-jwt-dest-for-token-exchange branch April 16, 2026 10:09
@gonzaloriestra

gonzaloriestra commented Apr 16, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@lizkenyon@zzooeeyy thanks a lot for your help! Do you want me to create a new release or how do you usually handle this?

@lizkenyonlizkenyon mentioned this pull request Jul 29, 2026
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lizkenyonlizkenyonlizkenyon approved these changes
@zzooeeyyzzooeeyyAwaiting requested review from zzooeeyy

Assignees

No one assigned

Labels

Hackeronesecurity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gonzaloriestra@lizkenyon@zzooeeyy