Skip to content

Adds support for dev - #96

Merged
mlhamel merged 2 commits into
masterfrom
adds-support-for-dev
May 1, 2018
Merged

Adds support for dev#96
mlhamel merged 2 commits into
masterfrom
adds-support-for-dev

Conversation

@mlhamel

Copy link
Copy Markdown
Contributor

Make things easier for developing

@mlhamel
mlhamel requested a review from piorApril 18, 2018 16:06
Comment threaddev.yml Outdated
commands:
lint:
desc: "Check for Python style & syntax errors in all Python files"
run: pylint --rcfile=pylintrc shopify_python tests setup.py

@piorpiorApr 19, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Makefile it's only tests.shopify_python.
The tests.functional module is intentionally full of errors.

@mlhamel

Copy link
Copy Markdown
ContributorAuthor

We could decide to completely dump the Makefile and only use dev but ...

pior
pior approved these changes May 1, 2018

@piorpior left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start with this.

@mlhamel
mlhamel merged commit 16c650c into masterMay 1, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mlhamel@pior