Skip to content

fix: pre-warm wiki index on service worker startup; fix iOS UI navigation delegate (v2.3.0) - #22

Merged
kiyarose merged 3 commits into
mainfrom
copilot/investigate-flean-ui-redirect-issue
Apr 12, 2026
Merged

fix: pre-warm wiki index on service worker startup; fix iOS UI navigation delegate (v2.3.0)#22
kiyarose merged 3 commits into
mainfrom
copilot/investigate-flean-ui-redirect-issue

Conversation

CopilotAI commented Apr 12, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor
  • JS-0116: Remove async from warmIndex() in both wiki-data-manager.js files (function returns a Promise directly, no await needed)
  • SW-W1023: Replace Bundle.main.resourceURL! force-unwrap with a safe let resourceURL = Bundle.main.resourceURL binding in WebViewContainer.swift
  • SW-W1022: Change WKNavigation! to WKNavigation? in the didFinish delegate method signature

@kiyarose
fix: pre-warm wiki index on startup and fix iOS UI navigation delegat…
f654093
…e, bump to 2.3.0
Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/85ef0bde-c484-413d-b06a-3f226ff8c228
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
@kiyarose
kiyarose marked this pull request as ready for review April 12, 2026 12:01
CopilotAI review requested due to automatic review settings April 12, 2026 12:01
@deepsource-autofix
style: format code with PHP CS Fixer, StandardJS and swift-format
c36df15
This commit fixes the style issues introduced in f654093 according to the output
from PHP CS Fixer, StandardJS and swift-format.
Details: #22
@kiyarose
kiyarose marked this pull request as draft April 12, 2026 12:01
@kiyarose
kiyarose marked this pull request as ready for review April 12, 2026 12:01
@deepsource-io

deepsource-ioBot commented Apr 12, 2026•
edited
Loading

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in a70cbb7...548b3f5 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall GradeSecurity

Reliability

Complexity

Hygiene

Code Review Summary

AnalyzerStatusUpdated (UTC)Details
PHPApr 12, 2026 12:09p.m.Review ↗
ShellApr 12, 2026 12:09p.m.Review ↗
JavaScriptApr 12, 2026 12:09p.m.Review ↗
SwiftApr 12, 2026 12:09p.m.Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

This comment was marked as outdated.

Sign in to view

@kiyarose
fix: address DeepSource findings - remove async from warmIndex, safe-…
548b3f5
…unwrap resourceURL, use optional WKNavigation
Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/649826ec-06e9-407d-b1e4-56c99779f8cc
Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
CopilotAI requested a review from kiyaroseApril 12, 2026 12:09
@kiyarose
kiyarose enabled auto-merge April 12, 2026 12:10
@kiyarose
kiyarose merged commit f6ff57e into mainApr 12, 2026
7 checks passed
@kiyarose
kiyarose deleted the copilot/investigate-flean-ui-redirect-issue branch April 12, 2026 12:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
@kiyarosekiyarosekiyarose approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kiyarosekiyarose

Copilot code reviewCopilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kiyarose