Uh oh!
There was an error while loading. Please reload this page.
Bump version to 2.11.0 and fix Tauri window close handler race - #18
Conversation
|
| Overall Grade | Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Rust | Apr 6, 2026 1:08p.m. | Review ↗ |
…odal-dialog-behavior-issues
There was a problem hiding this comment.
Pull request overview
This PR bumps the app version to 2.11.0 across the macOS Xcode project and key cross-platform (Tauri) config files, and adjusts the Tauri window close handler to avoid re-entry/race issues while only prompting when there is note data.
Changes:
- Bump
MARKETING_VERSIONinJot.xcodeproj/project.pbxprojfrom2.6.5to2.11.0across configurations. - Bump cross-platform version fields in
cross-platform/package.jsonandcross-platform/src-tauri/tauri.conf.jsonto2.11.0. - Rework the Tauri
onCloseRequestedflow incross-platform/src/main.jsto short-circuit when bypassing, avoid unnecessary prompts, and prevent re-entry while the dialog is open.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Jot.xcodeproj/project.pbxproj | Updates macOS app marketing version to 2.11.0. |
| cross-platform/src/main.js | Refines the close-request interception/prompting logic to avoid re-entry/races. |
| cross-platform/src-tauri/tauri.conf.json | Updates Tauri bundle/app version to 2.11.0. |
| cross-platform/package.json | Updates npm package version to 2.11.0. |
Comments suppressed due to low confidence (1)
cross-platform/src/main.js:135
- The explanatory comment above the close handler is now inaccurate: it still mentions
closeApprovedand says you "Always call event.preventDefault()", but the handler now usesshouldBypassClosePromptand only callspreventDefault()whenhasDatais true. Please update the comment so it matches the current logic (and remove the outdated variable name).
pinBtn.classList.toggle("pinned", pinned);
pinBtn.title = pinned ? "Unpin window" : "Pin window";
pinBtn.setAttribute("aria-label", pinned ? "Unpin window" : "Pin window");
setStatus(pinned ? "Pinned on top" : "Not pinned");
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
2.6.5to2.11.0across native and cross-platform configs to reflect a new release.Description
MARKETING_VERSIONin the Xcode project (Jot.xcodeproj/project.pbxproj) for all build configurations from2.6.5to2.11.0.cross-platform/package.jsonandcross-platform/src-tauri/tauri.conf.jsonfrom2.6.5to2.11.0.cross-platform/src/main.jsby renamingcloseApprovedtoshouldBypassClosePrompt, short-circuiting when the handler has already approved closure, moving thehasDatacheck earlier to avoid unnecessary prompts, ensuringevent.preventDefault()is only called when prompting, preventing re-entry viaisCloseDialogOpen, and settingshouldBypassClosePromptbefore callingawait TAURI.window.appWindow.close()with proper error handling.Testing
Codex Task