-
Notifications
You must be signed in to change notification settings - Fork 2
chore: 레포지토리 위생 및 CI 검증 보강 #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8d8cc24
fix: 로컬 환경 파일 추적 제거
Siul49 fcee40a
chore: CI 검증 범위 보강
Siul49 1f8b880
refactor: 일정 메모리 저장소 명명 정리
Siul49 83cec4f
chore: 오래된 스켈레톤 문서 정리
Siul49 b965f9e
fix: ICS 파서와 Supabase 환경 검증 보강
Siul49 b6f3c8c
chore: package-lock 의존성 동기화
Siul49 1fab55c
chore: CI 테스트 환경 변수 추가
Siul49 9a2168c
fix: ICS 파서 타입 좁히기 보강
Siul49 99a7eb0
docs: 제품 문서 버전 구조 정리
Siul49 4e20499
chore: 의존성 보안 패치 동기화
Siul49 8920591
fix: CI clean install 재현성 보강
Siul49 194849b
chore: GitHub Actions 런타임 경고 정리
Siul49 e632bc6
fix: 레포 안정성과 문서 기준 보강
Siul49 2d60858
fix: npm10 lockfile 누락 패키지 보강
Siul49 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule availability-aggregation
deleted from
fdbed6
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,65 @@ | ||
| name: CI Pipeline | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - dev | ||
| push: | ||
| branches: | ||
| - main | ||
| - dev | ||
|
|
||
| jobs: | ||
| build_and_lint: | ||
| code_quality: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| NEXT_PUBLIC_BASE_URL: http://localhost:3000 | ||
| NEXT_PUBLIC_SUPABASE_URL: https://example-project.supabase.co | ||
| NEXT_PUBLIC_SUPABASE_ANON_KEY: test-anon-key | ||
| KAKAO_REST_API_KEY: test-kakao-key | ||
| KAKAO_REDIRECT_URI: http://localhost:3000/api/auth/kakao/callback | ||
| GOOGLE_CLIENT_ID: test-google-client-id | ||
| GOOGLE_CLIENT_SECRET: test-google-client-secret | ||
| DATABASE_URL: file:./ci.db | ||
|
|
||
| steps: | ||
| - name: 저장소 체크아웃 (Checkout Repository) | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Node.js 세팅 (Setup Node.js) | ||
| uses: actions/setup-node@v4 | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: '20' | ||
| node-version: "20" | ||
| cache: "npm" | ||
|
|
||
| - name: 패키지 설치 (Install Dependencies) | ||
| run: npm ci | ||
|
|
||
| - name: CI 전용 보안 키 생성 (Generate CI Secrets) | ||
| run: | | ||
| { | ||
| echo "JWT_SECRET=$(openssl rand -base64 32)" | ||
| echo "ENCRYPTION_SECRET=$(openssl rand -hex 32)" | ||
| } >> "$GITHUB_ENV" | ||
|
|
||
| - name: 데이터베이스 마이그레이션 (Database Migration) | ||
| run: npm run db:migrate | ||
|
|
||
| - name: 코드 린트 검사 (Lint Check) | ||
| run: npm run lint | ||
|
|
||
| - name: 테스트 실행 (Unit Test) | ||
| run: npm run test | ||
|
|
||
| - name: Next.js 빌드 테스트 (Build Test) | ||
| run: npm run build | ||
|
|
||
| - name: Playwright 브라우저 설치 (Chromium) | ||
| run: npx playwright install --with-deps chromium | ||
|
|
||
| - name: E2E 테스트 실행 (Chromium) | ||
| run: npm run test:e2e -- --project=chromium | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| name: 이슈 템플릿 검사 (Compliance Check) | ||
|
|
||
| permissions: | ||
| issues: read | ||
|
|
||
| on: | ||
| issues: | ||
| types: [opened, edited] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,7 @@ yarn-error.log* | |
| next-env.d.ts | ||
|
|
||
| # AI & Local configs | ||
| .claude/ | ||
| .agents/* | ||
| !.agents/docs/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # MOIM | ||
|
|
||
| MOIM은 주최자가 모임 링크를 만들고, 참여자가 로그인 없이 가능한 시간을 제출하면 공통 가능한 시간을 추천해 주는 일정 조율 앱입니다. | ||
|
|
||
| ## 빠른 시작 | ||
|
|
||
| ```powershell | ||
| npm ci | ||
| npm run db:migrate | ||
| npm run dev | ||
| ``` | ||
|
|
||
| 로컬 기본 DB는 `DATABASE_URL`이 없을 때 `file:./dev.db`를 사용합니다. 실제 배포나 공유 환경에서는 `.env.example`을 기준으로 `.env`를 준비하세요. | ||
|
|
||
| ## 검증 명령 | ||
|
|
||
| ```powershell | ||
| npm run lint | ||
| npm run test | ||
| npm run test:coverage | ||
| npm run build | ||
| npm run test:e2e -- --project=chromium | ||
| ``` | ||
|
|
||
| `test`, `test:coverage`, `test:e2e`, `dev`는 실행 전에 로컬 SQLite schema를 보장합니다. | ||
|
|
||
| ## 먼저 읽을 문서 | ||
|
|
||
| 1. `docs/README.md`: 현재 문서 기준과 v1/v2 구분 | ||
| 2. `docs/v2/user-flow.md`: 최신 사용자 흐름 및 수익화 연결안 | ||
| 3. `docs/v1/codex-work-context.md`: 현재 개발 handoff와 주의점 | ||
| 4. `ARCHITECTURE.md`: 코드 구조와 테스트 전략 | ||
| 5. `convention.md`: 커밋, 브랜치, 이슈, PR 규칙 | ||
|
|
||
| ## 현재 안정성 기준 | ||
|
|
||
| - CI는 lint, unit test, build, Chromium E2E를 실행합니다. | ||
| - schedule 생성/참여 API는 process memory가 아니라 SQLite-backed Prisma store를 사용합니다. | ||
| - `.env`, 로컬 DB, Playwright 결과물, 문서 제출용 바이너리는 Git에 올리지 않습니다. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: Siul49/moim
Length of output: 219
🏁 Script executed:
Repository: Siul49/moim
Length of output: 174
🏁 Script executed:
Repository: Siul49/moim
Length of output: 2128
🌐 Web query:
actions/checkout persist-credentials default value true💡 Result:
The actions/checkout input persist-credentials defaults to true (i.e., credentials/token are persisted in the local git config unless you set persist-credentials: false). [1][2] Source detail: the actions/checkout documentation states the auth token is persisted in the local git config to enable authenticated git commands, and that you can opt out by setting persist-credentials: false; it also lists “Default: true” for persist-credentials in the action inputs section. [1][2]
Citations:
CI 공급망/자격증명 노출: actions 참조 SHA 고정 + checkout persist-credentials 차단 필요
.github/workflows/ci.yml에서actions/checkout@v6,actions/setup-node@v6가 SHA로 미고정되어 태그 재지정 시 파이프라인 무결성/재현성이 약해집니다(라인 31, 34).actions/checkout에persist-credentials: false가 없어서persist-credentials기본값(true)으로 토큰이 로컬 git config에 남을 수 있습니다.Why: CI 실행 환경에서 미고정 액션/자격증명 영속은 공급망·자격증명 노출 표면을 키웁니다.
How:
uses:는 40-hex 커밋 SHA로 고정하고, checkout step에with: persist-credentials: false를 명시하세요.최소 수정 예시
🧰 Tools
🪛 zizmor (1.25.2)
[warning] 30-31: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
[error] 31-31: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
[error] 34-34: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
🤖 Prompt for AI Agents