Skip to content

Add support for decoding webp images with animations - #1985

Merged
brianpopow merged 22 commits into
mainfrom
bp/webpanimation
May 17, 2022
Merged

Add support for decoding webp images with animations#1985
brianpopow merged 22 commits into
mainfrom
bp/webpanimation

Conversation

@brianpopow

@brianpopowbrianpopow commented Feb 9, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR will add support for decoding webp images with animations.

Related to #1802

@brianpopowbrianpopow changed the title WIP: Add support for decoding webp images with animationsAdd support for decoding webp images with animationsFeb 10, 2022
@JimBobSquarePantsJimBobSquarePants mentioned this pull request Feb 26, 2022
Closed
@JimBobSquarePants
JimBobSquarePants requested a review from a teamMarch 7, 2022 02:42
@JimBobSquarePants

JimBobSquarePants commented Mar 15, 2022

Copy link
Copy Markdown
Member

I think this one will have to wait 'til after 2.1 It's a lot to review. You're a machine!

@JimBobSquarePantsJimBobSquarePants added this to the Future milestone Mar 15, 2022
@brianpopow

brianpopow commented Mar 15, 2022

Copy link
Copy Markdown
CollaboratorAuthor

I think this one will have to wait 'til after 2.1 It's a lot to review. You're a machine!

Sure, no problem

@brianpopow
Merge remote-tracking branch 'origin/main' into bp/webpanimation
5a1ad2f
# Conflicts:
#	src/ImageSharp/Formats/Webp/WebpDecoder.cs
@JimBobSquarePantsJimBobSquarePants modified the milestones: Future, 3.0.0Mar 27, 2022
@brianpopow
Merge remote-tracking branch 'origin/main' into bp/webpanimation
51160a4
# Conflicts:
#	src/ImageSharp/Formats/Webp/WebpDecoderCore.cs
#	tests/ImageSharp.Tests/TestImages.cs
@brianpopow
Add missing dispose of webpInfo
89d1582
@JimBobSquarePants

JimBobSquarePants commented Apr 28, 2022

Copy link
Copy Markdown
Member

@brianpopow I've started reviewing this. Late now though so will pick up tomorrow.

@iambipinpaul

iambipinpaul commented Apr 29, 2022

Copy link
Copy Markdown

Does this PR also handles support for Encode animated webp images.

ie converting Gif to Webp

#1802

@brianpopow

brianpopow commented Apr 29, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Does this PR also handles support for Encode animated webp images.

ie converting Gif to Webp

#1802

No, only decoding is covered with this PR, but I plan to add support for encoding once this PR is merged.

JimBobSquarePants
JimBobSquarePants approved these changes May 17, 2022
View reviewed changes

@JimBobSquarePantsJimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work 👍

@brianpopow
brianpopow merged commit c661ab1 into mainMay 17, 2022
@brianpopow
brianpopow deleted the bp/webpanimation branch May 17, 2022 12:57
@iambipinpaul

iambipinpaul commented May 17, 2022

Copy link
Copy Markdown

Hope support for encoding webp images with animations is coming soon.

@JimBobSquarePants

JimBobSquarePants commented May 17, 2022

Copy link
Copy Markdown
Member

@iambipinpaul yeah no mate. Don’t comment with rubbish like that. Do it again and you’ll be banned.

It happens when it happens. Everyone contributing does so in their spare time.

@iambipinpaul

iambipinpaul commented May 18, 2022

Copy link
Copy Markdown

Yes, I know.
I will keep this in mind but my intentions was not like demanding here.

Maybe English is not my first language so.

Thank you!

@brianpopowbrianpopow mentioned this pull request Jun 16, 2022
Closed
4 tasks
This was referenced Sep 29, 2025
Closed
Closed
@dependabotdependabotBot mentioned this pull request Oct 13, 2025
Closed
@dependabotdependabotBot mentioned this pull request Nov 3, 2025
Closed
This was referenced Nov 17, 2025
Closed
Closed
@dependabotdependabotBot mentioned this pull request Dec 18, 2025
Closed
@dependabotdependabotBot mentioned this pull request Feb 3, 2026
Merged
@dependabotdependabotBot mentioned this pull request Mar 1, 2026
Merged
This was referenced Mar 23, 2026
Closed
Open
This was referenced Apr 26, 2026
Closed
Closed
This was referenced Jun 2, 2026
Closed
Open
This was referenced Jun 24, 2026
Closed
Open
@dependabotdependabotBot mentioned this pull request Jul 21, 2026
Open
@dependabotdependabotBot mentioned this pull request Aug 7, 2026
Closed
@dependabotdependabotBot mentioned this pull request Aug 18, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JimBobSquarePantsJimBobSquarePantsJimBobSquarePants approved these changes

Assignees

No one assigned

Labels

formats:webp

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@brianpopow@JimBobSquarePants@iambipinpaul