Skip to content

Use System.Half for HalfTypeHelper - #2233

Merged
JimBobSquarePants merged 4 commits into
mainfrom
js/system-half
Sep 16, 2022
Merged

Use System.Half for HalfTypeHelper#2233
JimBobSquarePants merged 4 commits into
mainfrom
js/system-half

Conversation

@JimBobSquarePants

@JimBobSquarePantsJimBobSquarePants commented Sep 16, 2022

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Replaces our incredibly complex custom packing code with System.Half plus casting.

@JimBobSquarePantsJimBobSquarePants added this to the 3.0.0 milestone Sep 16, 2022
teo-tsirpanis
teo-tsirpanis reviewed Sep 16, 2022
View reviewed changes
Comment threadsrc/ImageSharp/PixelFormats/HalfTypeHelper.cs Outdated
teo-tsirpanis
teo-tsirpanis reviewed Sep 16, 2022
View reviewed changes
Comment threadsrc/ImageSharp/PixelFormats/HalfTypeHelper.cs Outdated
@JimBobSquarePants@teo-tsirpanis
Update src/ImageSharp/PixelFormats/HalfTypeHelper.cs
6e7ca25
Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
@JimBobSquarePants@teo-tsirpanis
Update src/ImageSharp/PixelFormats/HalfTypeHelper.cs
13701d1
Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
@JimBobSquarePants
Formatting
eb864c5
brianpopow
brianpopow approved these changes Sep 16, 2022
View reviewed changes

@brianpopowbrianpopow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now 👍

@JimBobSquarePants
JimBobSquarePants merged commit 22a7cba into mainSep 16, 2022
@JimBobSquarePants
JimBobSquarePants deleted the js/system-half branch September 16, 2022 12:29
@teo-tsirpanisteo-tsirpanis mentioned this pull request Oct 13, 2022
Merged
This was referenced Sep 29, 2025
Closed
Closed
@dependabotdependabotBot mentioned this pull request Oct 13, 2025
Closed
@dependabotdependabotBot mentioned this pull request Nov 3, 2025
Closed
This was referenced Nov 17, 2025
Closed
Closed
@dependabotdependabotBot mentioned this pull request Dec 18, 2025
Closed
@dependabotdependabotBot mentioned this pull request Feb 3, 2026
Merged
@dependabotdependabotBot mentioned this pull request Mar 1, 2026
Merged
This was referenced Mar 23, 2026
Closed
Open
This was referenced Apr 26, 2026
Closed
Closed
This was referenced Jun 2, 2026
Closed
Open
This was referenced Jun 24, 2026
Closed
Open
@dependabotdependabotBot mentioned this pull request Jul 21, 2026
Open
@dependabotdependabotBot mentioned this pull request Aug 7, 2026
Closed
@dependabotdependabotBot mentioned this pull request Aug 18, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianpopowbrianpopowbrianpopow approved these changes
@antonfirsovantonfirsovAwaiting requested review from antonfirsov
@dlemstradlemstraAwaiting requested review from dlemstra
@tocsofttocsoftAwaiting requested review from tocsoft
+2 more reviewers
@tannergoodingtannergoodingtannergooding left review comments
@teo-tsirpanisteo-tsirpanisteo-tsirpanis left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:pixelformatscodequality

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JimBobSquarePants@tannergooding@teo-tsirpanis@brianpopow