Skip to content

Fix handling gif encoding for global palettes. - #2614

Merged
JimBobSquarePants merged 2 commits into
release/3.1.xfrom
js/gif-global-256-no-trans-fix
Dec 11, 2023
Merged

Fix handling gif encoding for global palettes. #2614
JimBobSquarePants merged 2 commits into
release/3.1.xfrom
js/gif-global-256-no-trans-fix

Conversation

@JimBobSquarePants

@JimBobSquarePantsJimBobSquarePants commented Dec 11, 2023

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

See SixLabors/ImageSharp.Web#344 (comment)

When an input gif has a full, non-transparent global palette we should use own to allow deduplication. Same image is reduced by 26% on encode.

@JimBobSquarePants
JimBobSquarePants merged commit ad1b0e6 into release/3.1.xDec 11, 2023
@JimBobSquarePants
JimBobSquarePants deleted the js/gif-global-256-no-trans-fix branch December 11, 2023 12:01
@JimBobSquarePants
JimBobSquarePants restored the js/gif-global-256-no-trans-fix branch December 11, 2023 12:02
@JimBobSquarePantsJimBobSquarePants mentioned this pull request Dec 11, 2023
Merged
4 tasks
This was referenced Jul 30, 2025
Open
Open
Open
Open
This was referenced Sep 29, 2025
Closed
Closed
@dependabotdependabotBot mentioned this pull request Oct 13, 2025
Closed
@dependabotdependabotBot mentioned this pull request Nov 3, 2025
Closed
This was referenced Nov 17, 2025
Closed
Closed
@dependabotdependabotBot mentioned this pull request Dec 18, 2025
Closed
@dependabotdependabotBot mentioned this pull request Feb 3, 2026
Merged
@dependabotdependabotBot mentioned this pull request Mar 1, 2026
Merged
@dependabotdependabotBot mentioned this pull request Mar 14, 2026
Closed
This was referenced Mar 23, 2026
Closed
Open
@dependabotdependabotBot mentioned this pull request Apr 18, 2026
Open
This was referenced Apr 26, 2026
Closed
Closed
This was referenced Jun 2, 2026
Closed
Open
This was referenced Jun 19, 2026
Open
Closed
@dependabotdependabotBot mentioned this pull request Jun 27, 2026
Open
@dependabotdependabotBot mentioned this pull request Jul 21, 2026
Open
@dependabotdependabotBot mentioned this pull request Aug 7, 2026
Closed
@dependabotdependabotBot mentioned this pull request Aug 18, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tocsofttocsofttocsoft approved these changes
@antonfirsovantonfirsovAwaiting requested review from antonfirsov
@dlemstradlemstraAwaiting requested review from dlemstra
@brianpopowbrianpopowAwaiting requested review from brianpopow

Assignees

No one assigned

Labels

bugformats:gif

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JimBobSquarePants@tocsoft