Skip to content

Fix MacOS jobs - #2728

Merged
JimBobSquarePants merged 3 commits into
mainfrom
test-ci
Apr 26, 2024
Merged

Fix MacOS jobs#2728
JimBobSquarePants merged 3 commits into
mainfrom
test-ci

Conversation

@antonfirsov

@antonfirsovantonfirsov commented Apr 25, 2024

Copy link
Copy Markdown
Member

Dummy PR to run against macos-latest on CI.

As noted in #2728 (comment), we need to use macos-13 to get the tests running.

In long term we need to migrate away from using System.Drawing.Common reference implementations, at least on Mac.

@antonfirsov
antonfirsov marked this pull request as draft April 25, 2024 20:02
@tocsoft

Copy link
Copy Markdown
Member

@antonfirsov the issue is likely due to macos-latest now using an arm runner

If you are wondering why your macos-latest builds on @GitHub are failing it might be because macos-latest is now use the macos-14 arm64 runners. If you want the x64 runners you can use macos-13 instead.

— 🧙‍♂️Dirk Lemstra (@MagickNET) April 25, 2024

Comment threadtests/ImageSharp.Tests/TestFormat.cs Outdated
@antonfirsovantonfirsov changed the title Test CIFix MacOS jobsApr 25, 2024
@antonfirsov
antonfirsov marked this pull request as ready for review April 25, 2024 20:31
@antonfirsov

Copy link
Copy Markdown
MemberAuthor

Turned this into an actual PR @JimBobSquarePants if you want to merge and move on.

@JimBobSquarePants
JimBobSquarePants merged commit b8cf630 into mainApr 26, 2024
@JimBobSquarePants
JimBobSquarePants deleted the test-ci branch April 26, 2024 03:39
This was referenced Aug 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@antonfirsov@tocsoft@JimBobSquarePants