Skip to content

V3 TIFF : Allow additional and undefined extra samples - #2942

Merged
JimBobSquarePants merged 2 commits into
release/3.1.xfrom
js/v3-tiff-extra-samples
Jun 12, 2025
Merged

V3 TIFF : Allow additional and undefined extra samples#2942
JimBobSquarePants merged 2 commits into
release/3.1.xfrom
js/v3-tiff-extra-samples

Conversation

@JimBobSquarePants

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Backport of #2941 for V3

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports support for additional and undefined extra samples in TIFF images. The changes include:

  • Adding a new test image constant and theory test for extra samples.
  • Adding a new enum member to handle CorelDRAW-specific unassociated alpha data.
  • Updating the TIFF decoder options parser to handle the new extra sample type.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

FileDescription
tests/ImageSharp.Tests/TestImages.csAdded constant for extra samples test image
tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.csAdded new test case for extra samples
src/ImageSharp/Formats/Tiff/TiffExtraSampleType.csIntroduced CorelDrawUnassociatedAlphaData enum value
src/ImageSharp/Formats/Tiff/TiffDecoderOptionsParser.csModified logic to parse TIFF extra sample data and patch CorelDRAW values

Comment threadsrc/ImageSharp/Formats/Tiff/TiffDecoderOptionsParser.cs
@JimBobSquarePants
JimBobSquarePants merged commit 9c011b7 into release/3.1.xJun 12, 2025
@JimBobSquarePants
JimBobSquarePants deleted the js/v3-tiff-extra-samples branch June 12, 2025 12:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@JimBobSquarePants