This repository was archived by the owner on Nov 12, 2025. It is now read-only.
v1.8.1 copy limit order config per collection - #191
Merged
Merged
Conversation
Merged
Skitzzy
approved these changes
Oct 23, 2025
MotokoKusanagi-aka-Major
approved these changes
Oct 23, 2025
MotokoKusanagi-aka-Major
left a comment
Contributor
There was a problem hiding this comment.
LTGM, just a minor comment
https://github.com/SizeCredit/size-solidity/pull/191/files#r2456056432
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specs
End result: market-specific controls AND collection-specific controls
Downsides
Requirements
R1
User can configure all
CopyLimitOrderConfigparameters per collectionR2
There is no per-chain global
CopyLimitOrderConfig. Per-collection is the maximum granularityR3
Per-market has precedence over per-collection. Ie, if the user has both configurations, we choose the per-market configuration