Conversation
## Description <!-- Please explain why you are making this pull request. --> <!-- Start writing below this line --> I made this pull request because I fixed the Command Hub bug and made this plugin support the experimental version of slimefun (1.21) ## Proposed changes <!-- Please explain what changes you have made to the code. --> <!-- Start writing below this line --> I changed some code in some files to adjust the slimefun experimental (1.21) and minecraft 1.21.4 api, then I also changed the command_hub.java code to fix the bug ## Related Issues (if applicable) <!-- Please tag any Issues related to your Pull Request --> <!-- Syntax: "Resolves #000" --> <!-- Start writing below this line --> Resolve #24 ## Checklist <!-- Here is a little checklist you can follow. --> <!-- Click on these checkboxes after you created the pull request. --> <!-- Don't worry, these are not requirements. They only serve as guidance. --> - [ ✓] I have fully tested the proposed changes and promise that they will not break everything into chaos. - [ ✓] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them. - [✓ ] I followed the existing code standards and didn't mess up the formatting. - [✓ ] I did my best to add documentation to any public classes or methods I added. - [ ] I have added `Nonnull` and `Nullable` annotations to my methods to indicate their behaviour for null values - [ ] I added sufficient Unit Tests to cover my code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )