build: put .NET inside the local gates instead of one trailing CI step by brentrager · Pull Request #68 · SmooAI/file

brentrager · 2026-08-20T18:11:04Z

Problem

package.json had no dotnet:* scripts. So every one of these silently skipped a fifth of the codebase:

gate	reached .NET before?
`pnpm test`	❌
`pnpm build`	❌
`pnpm format:check`	❌ (TypeScript only)
`pnpm check-all` — "full CI parity" per CLAUDE.md	❌
`.husky/pre-commit` (chains the above)	❌

The only thing exercising the .NET port was a separate trailing step in pr-checks.yml. A developer could run every local gate green and still break the port; CLAUDE.md didn't even have a .NET section.

Fix

New dotnet:build, dotnet:test, dotnet:format, dotnet:format:check, wired into build, test, format, format:check.
format:check now chains all five languages. Previously it was oxfmt --check . and CI chained the other four by hand — two definitions of "formatted" that could drift apart. The CI step is now just pnpm format:check.
The trailing Build and test .NET step in pr-checks.yml is removed: pnpm build and pnpm test now cover it. (release.yml's copy is left alone — it sits next to dotnet pack.)
check-all collapses to typecheck && lint && format:check && test && build. Nothing is lost: each of those already fans out per language. It just stops listing half of them twice.
CLAUDE.md gets a .NET section and states that the SDK is now a prerequisite for pnpm test.

Corrected finding

The brief expected dotnet format --verify-no-changes to surface drift ("C# formatting has never been checked in this repo"). It passes clean as-is — nothing to fix. The gap was purely that nothing ran it locally.

Verification that the gate is real

Hand-broke whitespace in FileMetadata.cs → pnpm dotnet:format:check exits 2 with error WHITESPACE. Restored → green.
Deleted every obj/ and bin/ and re-ran → passes with no prior dotnet restore, so the CI ordering (format check before build) is safe.
pnpm test now reports the 46 .NET tests alongside TS/Python/Rust/Go.

🤖 Generated with Claude Code

https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

changeset-bot · 2026-08-20T18:11:14Z

🦋 Changeset detected

Latest commit: bf172c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@smooai/file	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

`package.json` had no `dotnet:*` scripts at all, so `pnpm test`, `pnpm build`, `pnpm format:check` and `pnpm check-all` — the last of which CLAUDE.md calls "full CI parity" — every one of them silently skipped a fifth of the codebase. The husky pre-commit chains those same scripts, so it skipped it too. The only thing exercising .NET was a separate trailing step in pr-checks.yml, which means a developer could run every local gate green and still break the port. - Adds `dotnet:build` / `dotnet:test` / `dotnet:format` / `dotnet:format:check` and wires them into `build`, `test`, `format` and `format:check`. - `format:check` now chains all five languages, so the local gate and the CI step cannot disagree about what "formatted" means; pr-checks.yml's Format step becomes plain `pnpm format:check`, and its trailing .NET step goes away as a duplicate of `pnpm build` + `pnpm test`. - `check-all` gets shorter without losing coverage: `typecheck`, `lint`, `test` and `format:check` already fan out per language. - CLAUDE.md gains the .NET section it never had, and says the SDK is now a prerequisite for `pnpm test`. `dotnet format --verify-no-changes` passes as-is — C# formatting has genuinely never drifted, so there is nothing to clean up here. Verified the check is real by hand-breaking whitespace in FileMetadata.cs (exit 2) and from a clean tree with obj/ and bin/ deleted (no prior restore needed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

brentrager · 2026-08-20T18:11:04Z

Problem

package.json had no dotnet:* scripts. So every one of these silently skipped a fifth of the codebase:

gate	reached .NET before?
`pnpm test`	❌
`pnpm build`	❌
`pnpm format:check`	❌ (TypeScript only)
`pnpm check-all` — "full CI parity" per CLAUDE.md	❌
`.husky/pre-commit` (chains the above)	❌

The only thing exercising the .NET port was a separate trailing step in pr-checks.yml. A developer could run every local gate green and still break the port; CLAUDE.md didn't even have a .NET section.

Fix

New dotnet:build, dotnet:test, dotnet:format, dotnet:format:check, wired into build, test, format, format:check.
format:check now chains all five languages. Previously it was oxfmt --check . and CI chained the other four by hand — two definitions of "formatted" that could drift apart. The CI step is now just pnpm format:check.
The trailing Build and test .NET step in pr-checks.yml is removed: pnpm build and pnpm test now cover it. (release.yml's copy is left alone — it sits next to dotnet pack.)
check-all collapses to typecheck && lint && format:check && test && build. Nothing is lost: each of those already fans out per language. It just stops listing half of them twice.
CLAUDE.md gets a .NET section and states that the SDK is now a prerequisite for pnpm test.

Corrected finding

The brief expected dotnet format --verify-no-changes to surface drift ("C# formatting has never been checked in this repo"). It passes clean as-is — nothing to fix. The gap was purely that nothing ran it locally.

Verification that the gate is real

Hand-broke whitespace in FileMetadata.cs → pnpm dotnet:format:check exits 2 with error WHITESPACE. Restored → green.
Deleted every obj/ and bin/ and re-ran → passes with no prior dotnet restore, so the CI ordering (format check before build) is safe.
pnpm test now reports the 46 .NET tests alongside TS/Python/Rust/Go.

🤖 Generated with Claude Code

https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

changeset-bot · 2026-08-20T18:11:14Z

🦋 Changeset detected

Latest commit: bf172c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@smooai/file	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

`package.json` had no `dotnet:*` scripts at all, so `pnpm test`, `pnpm build`, `pnpm format:check` and `pnpm check-all` — the last of which CLAUDE.md calls "full CI parity" — every one of them silently skipped a fifth of the codebase. The husky pre-commit chains those same scripts, so it skipped it too. The only thing exercising .NET was a separate trailing step in pr-checks.yml, which means a developer could run every local gate green and still break the port. - Adds `dotnet:build` / `dotnet:test` / `dotnet:format` / `dotnet:format:check` and wires them into `build`, `test`, `format` and `format:check`. - `format:check` now chains all five languages, so the local gate and the CI step cannot disagree about what "formatted" means; pr-checks.yml's Format step becomes plain `pnpm format:check`, and its trailing .NET step goes away as a duplicate of `pnpm build` + `pnpm test`. - `check-all` gets shorter without losing coverage: `typecheck`, `lint`, `test` and `format:check` already fan out per language. - CLAUDE.md gains the .NET section it never had, and says the SDK is now a prerequisite for `pnpm test`. `dotnet format --verify-no-changes` passes as-is — C# formatting has genuinely never drifted, so there is nothing to clean up here. Verified the check is real by hand-breaking whitespace in FileMetadata.cs (exit 2) and from a clean tree with obj/ and bin/ deleted (no prior restore needed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

brentrager · 2026-08-20T18:11:04Z

Problem

package.json had no dotnet:* scripts. So every one of these silently skipped a fifth of the codebase:

gate	reached .NET before?
`pnpm test`	❌
`pnpm build`	❌
`pnpm format:check`	❌ (TypeScript only)
`pnpm check-all` — "full CI parity" per CLAUDE.md	❌
`.husky/pre-commit` (chains the above)	❌

The only thing exercising the .NET port was a separate trailing step in pr-checks.yml. A developer could run every local gate green and still break the port; CLAUDE.md didn't even have a .NET section.

Fix

New dotnet:build, dotnet:test, dotnet:format, dotnet:format:check, wired into build, test, format, format:check.
format:check now chains all five languages. Previously it was oxfmt --check . and CI chained the other four by hand — two definitions of "formatted" that could drift apart. The CI step is now just pnpm format:check.
The trailing Build and test .NET step in pr-checks.yml is removed: pnpm build and pnpm test now cover it. (release.yml's copy is left alone — it sits next to dotnet pack.)
check-all collapses to typecheck && lint && format:check && test && build. Nothing is lost: each of those already fans out per language. It just stops listing half of them twice.
CLAUDE.md gets a .NET section and states that the SDK is now a prerequisite for pnpm test.

Corrected finding

The brief expected dotnet format --verify-no-changes to surface drift ("C# formatting has never been checked in this repo"). It passes clean as-is — nothing to fix. The gap was purely that nothing ran it locally.

Verification that the gate is real

Hand-broke whitespace in FileMetadata.cs → pnpm dotnet:format:check exits 2 with error WHITESPACE. Restored → green.
Deleted every obj/ and bin/ and re-ran → passes with no prior dotnet restore, so the CI ordering (format check before build) is safe.
pnpm test now reports the 46 .NET tests alongside TS/Python/Rust/Go.

🤖 Generated with Claude Code

https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

changeset-bot · 2026-08-20T18:11:14Z

🦋 Changeset detected

Latest commit: bf172c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@smooai/file	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

`package.json` had no `dotnet:*` scripts at all, so `pnpm test`, `pnpm build`, `pnpm format:check` and `pnpm check-all` — the last of which CLAUDE.md calls "full CI parity" — every one of them silently skipped a fifth of the codebase. The husky pre-commit chains those same scripts, so it skipped it too. The only thing exercising .NET was a separate trailing step in pr-checks.yml, which means a developer could run every local gate green and still break the port. - Adds `dotnet:build` / `dotnet:test` / `dotnet:format` / `dotnet:format:check` and wires them into `build`, `test`, `format` and `format:check`. - `format:check` now chains all five languages, so the local gate and the CI step cannot disagree about what "formatted" means; pr-checks.yml's Format step becomes plain `pnpm format:check`, and its trailing .NET step goes away as a duplicate of `pnpm build` + `pnpm test`. - `check-all` gets shorter without losing coverage: `typecheck`, `lint`, `test` and `format:check` already fan out per language. - CLAUDE.md gains the .NET section it never had, and says the SDK is now a prerequisite for `pnpm test`. `dotnet format --verify-no-changes` passes as-is — C# formatting has genuinely never drifted, so there is nothing to clean up here. Verified the check is real by hand-breaking whitespace in FileMetadata.cs (exit 2) and from a clean tree with obj/ and bin/ deleted (no prior restore needed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

brentrager · 2026-08-20T18:11:04Z

Problem

package.json had no dotnet:* scripts. So every one of these silently skipped a fifth of the codebase:

gate	reached .NET before?
`pnpm test`	❌
`pnpm build`	❌
`pnpm format:check`	❌ (TypeScript only)
`pnpm check-all` — "full CI parity" per CLAUDE.md	❌
`.husky/pre-commit` (chains the above)	❌

The only thing exercising the .NET port was a separate trailing step in pr-checks.yml. A developer could run every local gate green and still break the port; CLAUDE.md didn't even have a .NET section.

Fix

New dotnet:build, dotnet:test, dotnet:format, dotnet:format:check, wired into build, test, format, format:check.
format:check now chains all five languages. Previously it was oxfmt --check . and CI chained the other four by hand — two definitions of "formatted" that could drift apart. The CI step is now just pnpm format:check.
The trailing Build and test .NET step in pr-checks.yml is removed: pnpm build and pnpm test now cover it. (release.yml's copy is left alone — it sits next to dotnet pack.)
check-all collapses to typecheck && lint && format:check && test && build. Nothing is lost: each of those already fans out per language. It just stops listing half of them twice.
CLAUDE.md gets a .NET section and states that the SDK is now a prerequisite for pnpm test.

Corrected finding

The brief expected dotnet format --verify-no-changes to surface drift ("C# formatting has never been checked in this repo"). It passes clean as-is — nothing to fix. The gap was purely that nothing ran it locally.

Verification that the gate is real

Hand-broke whitespace in FileMetadata.cs → pnpm dotnet:format:check exits 2 with error WHITESPACE. Restored → green.
Deleted every obj/ and bin/ and re-ran → passes with no prior dotnet restore, so the CI ordering (format check before build) is safe.
pnpm test now reports the 46 .NET tests alongside TS/Python/Rust/Go.

🤖 Generated with Claude Code

https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

changeset-bot · 2026-08-20T18:11:14Z

🦋 Changeset detected

Latest commit: bf172c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@smooai/file	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

`package.json` had no `dotnet:*` scripts at all, so `pnpm test`, `pnpm build`, `pnpm format:check` and `pnpm check-all` — the last of which CLAUDE.md calls "full CI parity" — every one of them silently skipped a fifth of the codebase. The husky pre-commit chains those same scripts, so it skipped it too. The only thing exercising .NET was a separate trailing step in pr-checks.yml, which means a developer could run every local gate green and still break the port. - Adds `dotnet:build` / `dotnet:test` / `dotnet:format` / `dotnet:format:check` and wires them into `build`, `test`, `format` and `format:check`. - `format:check` now chains all five languages, so the local gate and the CI step cannot disagree about what "formatted" means; pr-checks.yml's Format step becomes plain `pnpm format:check`, and its trailing .NET step goes away as a duplicate of `pnpm build` + `pnpm test`. - `check-all` gets shorter without losing coverage: `typecheck`, `lint`, `test` and `format:check` already fan out per language. - CLAUDE.md gains the .NET section it never had, and says the SDK is now a prerequisite for `pnpm test`. `dotnet format --verify-no-changes` passes as-is — C# formatting has genuinely never drifted, so there is nothing to clean up here. Verified the check is real by hand-breaking whitespace in FileMetadata.cs (exit 2) and from a clean tree with obj/ and bin/ deleted (no prior restore needed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

brentrager · 2026-08-20T18:11:04Z

Problem

package.json had no dotnet:* scripts. So every one of these silently skipped a fifth of the codebase:

gate	reached .NET before?
`pnpm test`	❌
`pnpm build`	❌
`pnpm format:check`	❌ (TypeScript only)
`pnpm check-all` — "full CI parity" per CLAUDE.md	❌
`.husky/pre-commit` (chains the above)	❌

The only thing exercising the .NET port was a separate trailing step in pr-checks.yml. A developer could run every local gate green and still break the port; CLAUDE.md didn't even have a .NET section.

Fix

New dotnet:build, dotnet:test, dotnet:format, dotnet:format:check, wired into build, test, format, format:check.
format:check now chains all five languages. Previously it was oxfmt --check . and CI chained the other four by hand — two definitions of "formatted" that could drift apart. The CI step is now just pnpm format:check.
The trailing Build and test .NET step in pr-checks.yml is removed: pnpm build and pnpm test now cover it. (release.yml's copy is left alone — it sits next to dotnet pack.)
check-all collapses to typecheck && lint && format:check && test && build. Nothing is lost: each of those already fans out per language. It just stops listing half of them twice.
CLAUDE.md gets a .NET section and states that the SDK is now a prerequisite for pnpm test.

Corrected finding

The brief expected dotnet format --verify-no-changes to surface drift ("C# formatting has never been checked in this repo"). It passes clean as-is — nothing to fix. The gap was purely that nothing ran it locally.

Verification that the gate is real

Hand-broke whitespace in FileMetadata.cs → pnpm dotnet:format:check exits 2 with error WHITESPACE. Restored → green.
Deleted every obj/ and bin/ and re-ran → passes with no prior dotnet restore, so the CI ordering (format check before build) is safe.
pnpm test now reports the 46 .NET tests alongside TS/Python/Rust/Go.

🤖 Generated with Claude Code

https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

changeset-bot · 2026-08-20T18:11:14Z

🦋 Changeset detected

Latest commit: bf172c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@smooai/file	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

`package.json` had no `dotnet:*` scripts at all, so `pnpm test`, `pnpm build`, `pnpm format:check` and `pnpm check-all` — the last of which CLAUDE.md calls "full CI parity" — every one of them silently skipped a fifth of the codebase. The husky pre-commit chains those same scripts, so it skipped it too. The only thing exercising .NET was a separate trailing step in pr-checks.yml, which means a developer could run every local gate green and still break the port. - Adds `dotnet:build` / `dotnet:test` / `dotnet:format` / `dotnet:format:check` and wires them into `build`, `test`, `format` and `format:check`. - `format:check` now chains all five languages, so the local gate and the CI step cannot disagree about what "formatted" means; pr-checks.yml's Format step becomes plain `pnpm format:check`, and its trailing .NET step goes away as a duplicate of `pnpm build` + `pnpm test`. - `check-all` gets shorter without losing coverage: `typecheck`, `lint`, `test` and `format:check` already fan out per language. - CLAUDE.md gains the .NET section it never had, and says the SDK is now a prerequisite for `pnpm test`. `dotnet format --verify-no-changes` passes as-is — C# formatting has genuinely never drifted, so there is nothing to clean up here. Verified the check is real by hand-breaking whitespace in FileMetadata.cs (exit 2) and from a clean tree with obj/ and bin/ deleted (no prior restore needed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

brentrager · 2026-08-20T18:11:04Z

Problem

package.json had no dotnet:* scripts. So every one of these silently skipped a fifth of the codebase:

gate	reached .NET before?
`pnpm test`	❌
`pnpm build`	❌
`pnpm format:check`	❌ (TypeScript only)
`pnpm check-all` — "full CI parity" per CLAUDE.md	❌
`.husky/pre-commit` (chains the above)	❌

The only thing exercising the .NET port was a separate trailing step in pr-checks.yml. A developer could run every local gate green and still break the port; CLAUDE.md didn't even have a .NET section.

Fix

New dotnet:build, dotnet:test, dotnet:format, dotnet:format:check, wired into build, test, format, format:check.
format:check now chains all five languages. Previously it was oxfmt --check . and CI chained the other four by hand — two definitions of "formatted" that could drift apart. The CI step is now just pnpm format:check.
The trailing Build and test .NET step in pr-checks.yml is removed: pnpm build and pnpm test now cover it. (release.yml's copy is left alone — it sits next to dotnet pack.)
check-all collapses to typecheck && lint && format:check && test && build. Nothing is lost: each of those already fans out per language. It just stops listing half of them twice.
CLAUDE.md gets a .NET section and states that the SDK is now a prerequisite for pnpm test.

Corrected finding

The brief expected dotnet format --verify-no-changes to surface drift ("C# formatting has never been checked in this repo"). It passes clean as-is — nothing to fix. The gap was purely that nothing ran it locally.

Verification that the gate is real

Hand-broke whitespace in FileMetadata.cs → pnpm dotnet:format:check exits 2 with error WHITESPACE. Restored → green.
Deleted every obj/ and bin/ and re-ran → passes with no prior dotnet restore, so the CI ordering (format check before build) is safe.
pnpm test now reports the 46 .NET tests alongside TS/Python/Rust/Go.

🤖 Generated with Claude Code

https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

changeset-bot · 2026-08-20T18:11:14Z

🦋 Changeset detected

Latest commit: bf172c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@smooai/file	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

`package.json` had no `dotnet:*` scripts at all, so `pnpm test`, `pnpm build`, `pnpm format:check` and `pnpm check-all` — the last of which CLAUDE.md calls "full CI parity" — every one of them silently skipped a fifth of the codebase. The husky pre-commit chains those same scripts, so it skipped it too. The only thing exercising .NET was a separate trailing step in pr-checks.yml, which means a developer could run every local gate green and still break the port. - Adds `dotnet:build` / `dotnet:test` / `dotnet:format` / `dotnet:format:check` and wires them into `build`, `test`, `format` and `format:check`. - `format:check` now chains all five languages, so the local gate and the CI step cannot disagree about what "formatted" means; pr-checks.yml's Format step becomes plain `pnpm format:check`, and its trailing .NET step goes away as a duplicate of `pnpm build` + `pnpm test`. - `check-all` gets shorter without losing coverage: `typecheck`, `lint`, `test` and `format:check` already fan out per language. - CLAUDE.md gains the .NET section it never had, and says the SDK is now a prerequisite for `pnpm test`. `dotnet format --verify-no-changes` passes as-is — C# formatting has genuinely never drifted, so there is nothing to clean up here. Verified the check is real by hand-breaking whitespace in FileMetadata.cs (exit 2) and from a clean tree with obj/ and bin/ deleted (no prior restore needed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

brentrager · 2026-08-20T18:11:04Z

Problem

package.json had no dotnet:* scripts. So every one of these silently skipped a fifth of the codebase:

gate	reached .NET before?
`pnpm test`	❌
`pnpm build`	❌
`pnpm format:check`	❌ (TypeScript only)
`pnpm check-all` — "full CI parity" per CLAUDE.md	❌
`.husky/pre-commit` (chains the above)	❌

The only thing exercising the .NET port was a separate trailing step in pr-checks.yml. A developer could run every local gate green and still break the port; CLAUDE.md didn't even have a .NET section.

Fix

New dotnet:build, dotnet:test, dotnet:format, dotnet:format:check, wired into build, test, format, format:check.
format:check now chains all five languages. Previously it was oxfmt --check . and CI chained the other four by hand — two definitions of "formatted" that could drift apart. The CI step is now just pnpm format:check.
The trailing Build and test .NET step in pr-checks.yml is removed: pnpm build and pnpm test now cover it. (release.yml's copy is left alone — it sits next to dotnet pack.)
check-all collapses to typecheck && lint && format:check && test && build. Nothing is lost: each of those already fans out per language. It just stops listing half of them twice.
CLAUDE.md gets a .NET section and states that the SDK is now a prerequisite for pnpm test.

Corrected finding

The brief expected dotnet format --verify-no-changes to surface drift ("C# formatting has never been checked in this repo"). It passes clean as-is — nothing to fix. The gap was purely that nothing ran it locally.

Verification that the gate is real

Hand-broke whitespace in FileMetadata.cs → pnpm dotnet:format:check exits 2 with error WHITESPACE. Restored → green.
Deleted every obj/ and bin/ and re-ran → passes with no prior dotnet restore, so the CI ordering (format check before build) is safe.
pnpm test now reports the 46 .NET tests alongside TS/Python/Rust/Go.

🤖 Generated with Claude Code

https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

changeset-bot · 2026-08-20T18:11:14Z

🦋 Changeset detected

Latest commit: bf172c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@smooai/file	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

`package.json` had no `dotnet:*` scripts at all, so `pnpm test`, `pnpm build`, `pnpm format:check` and `pnpm check-all` — the last of which CLAUDE.md calls "full CI parity" — every one of them silently skipped a fifth of the codebase. The husky pre-commit chains those same scripts, so it skipped it too. The only thing exercising .NET was a separate trailing step in pr-checks.yml, which means a developer could run every local gate green and still break the port. - Adds `dotnet:build` / `dotnet:test` / `dotnet:format` / `dotnet:format:check` and wires them into `build`, `test`, `format` and `format:check`. - `format:check` now chains all five languages, so the local gate and the CI step cannot disagree about what "formatted" means; pr-checks.yml's Format step becomes plain `pnpm format:check`, and its trailing .NET step goes away as a duplicate of `pnpm build` + `pnpm test`. - `check-all` gets shorter without losing coverage: `typecheck`, `lint`, `test` and `format:check` already fan out per language. - CLAUDE.md gains the .NET section it never had, and says the SDK is now a prerequisite for `pnpm test`. `dotnet format --verify-no-changes` passes as-is — C# formatting has genuinely never drifted, so there is nothing to clean up here. Verified the check is real by hand-breaking whitespace in FileMetadata.cs (exit 2) and from a clean tree with obj/ and bin/ deleted (no prior restore needed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

brentrager · 2026-08-20T18:11:04Z

Problem

package.json had no dotnet:* scripts. So every one of these silently skipped a fifth of the codebase:

gate	reached .NET before?
`pnpm test`	❌
`pnpm build`	❌
`pnpm format:check`	❌ (TypeScript only)
`pnpm check-all` — "full CI parity" per CLAUDE.md	❌
`.husky/pre-commit` (chains the above)	❌

The only thing exercising the .NET port was a separate trailing step in pr-checks.yml. A developer could run every local gate green and still break the port; CLAUDE.md didn't even have a .NET section.

Fix

New dotnet:build, dotnet:test, dotnet:format, dotnet:format:check, wired into build, test, format, format:check.
format:check now chains all five languages. Previously it was oxfmt --check . and CI chained the other four by hand — two definitions of "formatted" that could drift apart. The CI step is now just pnpm format:check.
The trailing Build and test .NET step in pr-checks.yml is removed: pnpm build and pnpm test now cover it. (release.yml's copy is left alone — it sits next to dotnet pack.)
check-all collapses to typecheck && lint && format:check && test && build. Nothing is lost: each of those already fans out per language. It just stops listing half of them twice.
CLAUDE.md gets a .NET section and states that the SDK is now a prerequisite for pnpm test.

Corrected finding

The brief expected dotnet format --verify-no-changes to surface drift ("C# formatting has never been checked in this repo"). It passes clean as-is — nothing to fix. The gap was purely that nothing ran it locally.

Verification that the gate is real

Hand-broke whitespace in FileMetadata.cs → pnpm dotnet:format:check exits 2 with error WHITESPACE. Restored → green.
Deleted every obj/ and bin/ and re-ran → passes with no prior dotnet restore, so the CI ordering (format check before build) is safe.
pnpm test now reports the 46 .NET tests alongside TS/Python/Rust/Go.

🤖 Generated with Claude Code

https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC

changeset-bot · 2026-08-20T18:11:14Z

🦋 Changeset detected

Latest commit: bf172c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@smooai/file	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

`package.json` had no `dotnet:*` scripts at all, so `pnpm test`, `pnpm build`, `pnpm format:check` and `pnpm check-all` — the last of which CLAUDE.md calls "full CI parity" — every one of them silently skipped a fifth of the codebase. The husky pre-commit chains those same scripts, so it skipped it too. The only thing exercising .NET was a separate trailing step in pr-checks.yml, which means a developer could run every local gate green and still break the port. - Adds `dotnet:build` / `dotnet:test` / `dotnet:format` / `dotnet:format:check` and wires them into `build`, `test`, `format` and `format:check`. - `format:check` now chains all five languages, so the local gate and the CI step cannot disagree about what "formatted" means; pr-checks.yml's Format step becomes plain `pnpm format:check`, and its trailing .NET step goes away as a duplicate of `pnpm build` + `pnpm test`. - `check-all` gets shorter without losing coverage: `typecheck`, `lint`, `test` and `format:check` already fan out per language. - CLAUDE.md gains the .NET section it never had, and says the SDK is now a prerequisite for `pnpm test`. `dotnet format --verify-no-changes` passes as-is — C# formatting has genuinely never drifted, so there is nothing to clean up here. Verified the check is real by hand-breaking whitespace in FileMetadata.cs (exit 2) and from a clean tree with obj/ and bin/ deleted (no prior restore needed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC