Skip to content

uvdsl OIDC client - #657

Open
bourgeoa wants to merge 12 commits into
mainfrom
uvdsl
Open

uvdsl OIDC client#657
bourgeoa wants to merge 12 commits into
mainfrom
uvdsl

Conversation

@bourgeoa

@bourgeoabourgeoa commented May 20, 2026

Copy link
Copy Markdown
Contributor

Map solid-logic to local source in Jest
Mock @uvdsl/solid-oidc-client-browser for JSDOM tests Keep TypeScript config stable for linked workspace development Preserve pane behavior while upstream auth/session contracts change

Mock @uvdsl/solid-oidc-client-browser for JSDOM tests
Keep TypeScript config stable for linked workspace development
Preserve pane behavior while upstream auth/session contracts change
@bourgeoabourgeoa changed the title Map solid-logic to local source in Jestuvdsl OIDC clientMay 20, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Solid Panes to remain compatible with evolving Solid authentication/session contracts (notably around solid-logic and OIDC client implementations) while keeping existing pane behavior stable, and improving the local linked-workspace + Jest/JSDOM developer experience.

Changes:

  • Adds a Jest module mapper setup to optionally use a locally linked solid-logic source entrypoint and to mock OIDC client browser modules in JSDOM.
  • Updates UI auth checks (menu + header) to tolerate multiple session shapes and to proactively resolve the current user before rendering header state.
  • Adjusts the dev loader’s session initialization/login display to align with updated auth/session behavior.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
test/mocks/solid-oidc-client-browser.tsAdds a lightweight mock of the OIDC browser session API for JSDOM/Jest runs.
src/mainPage/menu.tsUpdates “logged-in” detection to support multiple session shapes.
src/mainPage/header.tsEnsures auth user state is resolved before computing/rendering header auth state.
README.mdDocuments worker same-origin requirement when panes are hosted via mashlib + solid-logic auth.
jest.config.mjsAdds conditional local solid-logic mapping and OIDC-client module mocks for tests.
dev/loader.tsUpdates dev loader session checks and display to work with newer auth/session contracts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadtest/mocks/solid-oidc-client-browser.ts
Comment threaddev/loader.ts
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bourgeoa@timea-solid