Uh oh!
There was an error while loading. Please reload this page.
#769 Prepare utils for Header component - #817
Merged
Merged
Conversation
NoelDeMartinforce-pushed
the
769-header
branch
2 times, most recently
from
June 29, 2026 14:21
be5cccc to
582cfdaComparetimea-solid
approved these changes
Jun 29, 2026
timea-solid
left a comment
Member
There was a problem hiding this comment.
Nice to see it come together more and more like the menu items, the mobile breakpoint again.
Do you think this will solve the duplicated loading of components?
Uh oh!
There was an error while loading. Please reload this page.
NoelDeMartinforce-pushed
the
769-header
branch
2 times, most recently
from
July 1, 2026 14:49
89d4817 to
575e1faCompareNoelDeMartin
marked this pull request as ready for review
July 1, 2026 15:01
This was referenced Jul 1, 2026
This was
linked to
issues
Jul 1, 2026
- SVG obtained from solidproject.org and cleaned up with svgomg.net - We're wrapping this custom icon as a normal component because it's easier, if we end up with a lot of these icon components we should consider moving them to some specialized solid-ui/icons/ export paths.
- Header component will be implemented in solid-panes instead - Implement customizable items menu in Account component - Add new design tokens - Remove v2 header and feature flags
- Defined breakpoints (only mobile for now) - Exported breakpoints.css for library consumers
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR blocked by: