Uh oh!
There was an error while loading. Please reload this page.
#828 Styles and other improvements - #836
Merged
Merged
Conversation
The previous import included the Native CSS reset from Web Awesome, which we don't want in order to avoid style conflicts.
NoelDeMartin
marked this pull request as draft
July 14, 2026 10:53
NoelDeMartin
marked this pull request as ready for review
July 14, 2026 10:54
Without this fix, importing the entire suite of components would register the provider after components like <solid-ui-account>, which would cause them to have the wrong context at mount time (and so register the listeners with the incorrect Auth context, etc.).
Without this code, the Avatar component would not work consistently. If it had worked at all until now, it's probably because some other part of the codebase was loading the profile. But components should work by themselves.
timea-solid
approved these changes
Jul 18, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.