Skip to content

Math module - #108

Open
kaylendog wants to merge 40 commits into
masterfrom
feat/skyezer/math
Open

Math module#108
kaylendog wants to merge 40 commits into
masterfrom
feat/skyezer/math

Conversation

@kaylendog

Copy link
Copy Markdown
Collaborator

Mathematics Module

See #106 for more details.

@kaylendogkaylendog self-assigned this Mar 28, 2021
@kaylendog
kaylendog changed the base branch from master to feat/jcx/major/modules-defMarch 28, 2021 11:42
@codecov

codecovBot commented Mar 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #108 (1446c64) into master (2c8da6c) will increase coverage by 2.24%.
The diff coverage is 57.28%.

Impacted file tree graph

@@ Coverage Diff @@## master #108 +/- ##
==========================================
+ Coverage 34.39% 36.64% +2.24% 
==========================================
Files 63 79 +16 Lines 2532 2827 +295 Branches 286 318 +32 ==========================================
+ Hits 871 1036 +165 - Misses 1597 1708 +111 - Partials 64 83 +19 
Impacted FilesCoverage Δ
...mbdogdiner/stickyapi/bukkit/util/LocationUtil.java0.00% <0.00%> (ø)
...dogdiner/stickyapi/bukkit/util/PlayerSelector.java0.00% <0.00%> (ø)
...dogdiner/stickyapi/common/arguments/Arguments.java0.00% <0.00%> (ø)
...m/dumbdogdiner/stickyapi/common/util/MathUtil.java0.00% <ø> (-25.00%)⬇️
...dumbdogdiner/stickyapi/common/util/NumberUtil.java52.17% <ø> (ø)
...m/dumbdogdiner/stickyapi/common/util/TimeUtil.java62.85% <0.00%> (ø)
...bdogdiner/stickyapi/math/function/CubicBezier.java0.00% <0.00%> (ø)
...dumbdogdiner/stickyapi/math/transform/Matrix3.java0.00% <0.00%> (ø)
.../stickyapi/math/transform/TranslationBuilder3.java0.00% <0.00%> (ø)
...com/dumbdogdiner/stickyapi/math/vector/Vector.java36.00% <36.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8da6c...1446c64. Read the comment docs.

@kaylendogkaylendog added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation feature New feature or request help wanted Extra attention is needed labels Mar 28, 2021
@kaylendogkaylendog linked an issue Mar 28, 2021 that may be closed by this pull request
@jcxldnjcxldn added this to the v3.0 (next) milestone Mar 29, 2021
@kaylendog
kaylendog changed the base branch from feat/jcx/major/modules-def to masterMarch 29, 2021 11:43
@kaylendogkaylendog linked an issue Apr 24, 2021 that may be closed by this pull request
@kaylendog
kaylendog marked this pull request as ready for review April 24, 2021 18:50
@kaylendog
kaylendog requested a review from a team as a code ownerApril 24, 2021 18:50
@kaylendog

Copy link
Copy Markdown
CollaboratorAuthor

Made RandomUtil more inclusive for integer methods, added RandomUtil.randomIntExclusive for exclusively exclusive exclusivity.

@aakatz3
aakatz3 self-requested a review June 19, 2021 01:26
@aakatz3

Copy link
Copy Markdown
Collaborator

If Common is going to depend on math, I would recommend making math a submodule of common.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filedocumentationImprovements or additions to documentationfeatureNew feature or requesthelp wantedExtra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Math module Ordinal Generator

4 participants

@kaylendog@aakatz3@ZachyFoxx@jcxldn