Add Battlenet Provider - #260
Conversation
joshbuker
left a comment
There was a problem hiding this comment.
Looks good at first glance! I'll take a closer look at this when I can and merge it into master.
joshbuker
left a comment
There was a problem hiding this comment.
Some minor things I noticed.
Add Site config to initializer
joshbuker
left a comment
There was a problem hiding this comment.
@jojoa looks good other than the eu.battle.net concern. Do you have time to look into their documentation? A link to their docs where it talks about which subdomains to use would be helpful for me to better understand their implementation of OAuth2.
I ve tested it. i can succesfully use the us domain with my eu account. so i think there are no problems. the doc says that only CN has an seperate Data Department. But i am not sure how this could be implemented. also the game infos could be different, but the general login info is same. so i dont think it is important for an auth Gem to have things like the Wow chars. |
|
any news here? |
joshbuker
left a comment
There was a problem hiding this comment.
If anything is broken, it should only affect people using this specific provider and can be fixed with a later update. Going to go ahead and merge this for now.
|
@jojoa You should be able to use this by pointing your Gemfile at the master branch of Sorcery via Github. I'm planning on focusing on the v1 release of Sorcery over the next week, so I probably won't cut a new release until after that's ready to deploy. |
I Added BattleNet as OAuth Provider as documented in theri api docu and tested it local.