Skip to content

Removed the link to inch-ci badge in README.md because it wad dead - #272

Merged
joshbuker merged 1 commit into
Sorcery:masterfrom
chanrute:delete_inch-ci_dead_link_in_README
Mar 15, 2021
Merged

joshbuker merged 1 commit into
Sorcery:masterfrom
chanrute:delete_inch-ci_dead_link_in_README

Conversation

@chanrute

@chanrute chanrute commented Feb 25, 2021

Copy link
Copy Markdown
Contributor

image

The link to the inch-ci badge in README.md because it was dead.

It seems that inch-ci.org is not working, and cannot access the site from the following URL.

The badge was not showing up in README.md for these reasons, so I removed it to improve the documentation.

Please ensure your pull request includes the following:

  • Description of changes
  • Update to CHANGELOG.md with short description and link to pull request
  • Changes have related RSpec tests that ensure functionality does not break

The link to the inch-ci badge in README.md because it was dead.

- Link: http://inch-ci.org/github/Sorcery/sorcery.svg?branch=master

It seems that `inch-ci.org` is not working,
and cannot access the site from the following URL.

- Main site: https://inch-ci.org/

The badge was not showing up in README.md for these reasons,
so I removed it to improve the documentation.

@joshbuker joshbuker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The badge not rendering is a periodic issue with Github caching, but it does appear that inch-ci went down in February and has yet to come back online. The author's twitter suggests no known ETA for it coming back up, and I don't think we really used it anyway, so I'm fine with removing the badge.

@chanrute

Copy link
Copy Markdown
Contributor Author

Thank you for your consideration. I thought it would be a good that the maintainers to make the decision on whether to use inci-ci or not.

@joshbuker
joshbuker merged commit 404862d into Sorcery:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants