Skip to content

Support Composer package manager - #1203

Merged
waynevanson merged 8 commits into
SortableJS:masterfrom
components:composer-support
Sep 24, 2020
Merged

Support Composer package manager#1203
waynevanson merged 8 commits into
SortableJS:masterfrom
components:composer-support

Conversation

@hawkeyetwolf

@hawkeyetwolfhawkeyetwolf commented Oct 27, 2017

Copy link
Copy Markdown
Contributor

After merging this PR, the RubaXa/Sortable repo can be submitted to Packagist.org under the RubaXa org. Clean and simple no more maintaining of forks. Hooray!

@hawkeyetwolfhawkeyetwolf mentioned this pull request Oct 27, 2017
Open
waynevanson
waynevanson approved these changes Apr 13, 2020
View reviewed changes

@waynevansonwaynevanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Who would've thought it'd be a PHP dependency? :)

@waynevanson

waynevanson commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

@owen-m1 mentioned something about this on discord the other day.

@owen-m1owen-m1 removed their assignment Aug 8, 2020
waynevanson
waynevanson suggested changes Aug 17, 2020
View reviewed changes
Comment threadcomposer.json Outdated
waynevanson
waynevanson approved these changes Aug 18, 2020
View reviewed changes

@waynevansonwaynevanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three years in the making on this one. Thank you!

waynevanson
waynevanson suggested changes Aug 18, 2020
View reviewed changes

@waynevansonwaynevanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for doing this but after some sleep I saw all the values I overlooked.
Would you be able to address these?

Comment threadcomposer.json Outdated
Comment threadcomposer.json Outdated
Comment threadcomposer.json Outdated
Comment threadcomposer.json Outdated
Comment threadcomposer.json Outdated
@waynevansonwaynevanson self-assigned this Sep 1, 2020
@waynevanson

waynevanson commented Sep 1, 2020

Copy link
Copy Markdown
Contributor

TODO: I'm going to pull this in change the code myself.

@hawkeyetwolf

hawkeyetwolf commented Sep 1, 2020

Copy link
Copy Markdown
ContributorAuthor

Thank you, @waynevanson. I've been meaning to make the changes but if you are free, please do 👍

@hawkeyetwolf

hawkeyetwolf commented Sep 1, 2020

Copy link
Copy Markdown
ContributorAuthor

Actually, just noticed you already made the code suggestions, I'll just go ahead and click the buttons, sorry for the delay...

hawkeyetwolfand others added 5 commits September 1, 2020 02:03
@hawkeyetwolf@waynevanson
Update repo source in composer.json
d3c19de
Co-authored-by: Wayne Van Son <waynevanson@gmail.com>
@hawkeyetwolf@waynevanson
Update "issues" link in composer.json
0294d16
Co-authored-by: Wayne Van Son <waynevanson@gmail.com>
@hawkeyetwolf@waynevanson
Update homepage link in composer.json
a1a1648
Co-authored-by: Wayne Van Son <waynevanson@gmail.com>
@hawkeyetwolf@waynevanson
Update package name in composer.json
008e1e2
Co-authored-by: Wayne Van Son <waynevanson@gmail.com>
@hawkeyetwolf
Remove legacy file from composer.json files list
262842b
@waynevanson
waynevanson merged commit 6d54aa6 into SortableJS:masterSep 24, 2020
@hawkeyetwolf
hawkeyetwolf deleted the composer-support branch September 25, 2020 04:05
@webhivewebhive mentioned this pull request Oct 23, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@waynevansonwaynevansonwaynevanson requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@waynevansonwaynevanson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hawkeyetwolf@waynevanson@owen-m1