Uh oh!
There was an error while loading. Please reload this page.
flake: add albert-sourceos package (fork w/ SourceOS plugin) - #50
Closed
mdheller wants to merge 4 commits into
Closed
flake: add albert-sourceos package (fork w/ SourceOS plugin)#50mdheller wants to merge 4 commits into
mdheller wants to merge 4 commits into
Conversation
mdheller
commented
Apr 19, 2026
ContributorAuthor
CI shows More importantly, upstream Albert is not OSI-open:
That’s incompatible with SourceOS constraints (open-source only) and with our need to ship a modified build including Recommendation:
I’ll open a replacement PR that removes Albert dependency and implements the open-source launcher palette. |
mdheller added a commit
that referenced
this pull request
Jul 29, 2026
) The health check ran `sourceos-boot rollback execute --execute || true`. That `|| true` turned the last line of defence into a reporting lie: the subcommand was dropped from sourceos-boot by PR #48, so on any host tracking HEAD the call is argparse exit 2, the unit logs "triggering rollback", and then reports success having done nothing. It survived only because flake.lock pins sourceos-boot-src to bc6dd8c, the commit before the removal — one `nix flake update` from disarming auto-rollback on stable-x86_64, canary-x86_64, exit-x86_64 and builder-aarch64, all of which set rollbackOnFailure = true. This branch runs precisely when the host is ALREADY unhealthy, so a rollback that cannot run is the worst possible thing to hide. Failure now logs what happened and exits 3 — distinct from the plain-unhealthy exit 2, so "unhealthy" and "unhealthy AND did not roll back" are different signals to whatever supervises the unit. Success is logged too, so the happy path is observable rather than inferred from silence. The subcommand itself is restored in sourceos-boot #50; this change is what stops the next such removal from being invisible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed: Albert is not OSI-open and is classified as
unfreeby nixpkgs.See discussion in comments:
SociOS-Linux/albertuses "Albert license v1.1" which permits redistribution only without modification and includes platform-targeting restrictions, making it incompatible with SourceOS constraints and with shipping a modified build includingplugins/sourceos.Replacement PR will pivot to an open-source launcher palette (Wayland-first; fuzzel/wofi/rofi) bound to Super+Space via
sourceos palette.