Uh oh!
There was an error while loading. Please reload this page.
Add merge-conflict marker check to PR template and contributing guide - #9
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1be5b948fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Merge-conflict marker check | ||
| rg -n '^(<{7}|={7}|>{7})' .github/PULL_REQUEST_TEMPLATE.md CHANGELOG.md CONTRIBUTING.md README.md asyncapi.agent-plane.patch.yaml asyncapi.yaml examples/community.json examples/rating.json openapi.agent-plane.patch.yaml openapi.yaml schemas/AgentSession.json schemas/Agreement.json schemas/AuthorityLink.json schemas/CapabilityToken.json schemas/Comment.json schemas/Community.json schemas/Connector.json schemas/DataRef.json schemas/DataSphere.json schemas/Dataset.json schemas/EntityField.json schemas/EventEnvelope.json schemas/Exception.json schemas/ExecutionDecision.json schemas/ExecutionSurface.json | ||
| git grep -nE '^(<{7}|={7}|>{7})' -- . |
There was a problem hiding this comment.
Invert merge-marker validation command
git grep -nE '^(<{7}|={7}|>{7})' -- . returns exit code 1 when no matches are found and 0 when conflict markers are present, so as written this “validation” step fails on clean trees and can pass when markers exist. This is especially problematic if contributors run the listed commands in a set -e shell or CI-style script, because the check’s success condition is backwards.
Useful? React with 👍 / 👎.
Motivation
Description
.github/PULL_REQUEST_TEMPLATE.mdandCONTRIBUTING.mdby inserting- [ ] No Git merge conflict markers remain in touched filesand thegit grep -nE '^(<{7}|={7}|>{7})' -- .validation step into the validation commands section.Testing
git grep -nE '^(<{7}|={7}|>{7})' -- .against the repository and it returned no matches, indicating no leftover conflict markers were present.Codex Task