Skip to content

Add merge-conflict marker check to PR template and contributing guide - #9

Merged
mdheller merged 2 commits into
mainfrom
codex/resolve-merge-conflicts-in-branch
Apr 8, 2026
Merged

Add merge-conflict marker check to PR template and contributing guide#9
mdheller merged 2 commits into
mainfrom
codex/resolve-merge-conflicts-in-branch

Conversation

@mdheller

Copy link
Copy Markdown
Contributor

Motivation

  • Ensure PR authors and contributors run a simple check to catch leftover Git merge conflict markers before committing or opening a PR.

Description

  • Added a checklist item and a repository check command for merge-conflict markers to .github/PULL_REQUEST_TEMPLATE.md and CONTRIBUTING.md by inserting - [ ] No Git merge conflict markers remain in touched files and the git grep -nE '^(<{7}|={7}|>{7})' -- . validation step into the validation commands section.

Testing

  • Ran the new merge-conflict check git grep -nE '^(<{7}|={7}|>{7})' -- . against the repository and it returned no matches, indicating no leftover conflict markers were present.

Codex Task

@mdheller
mdheller merged commit cb8faef into mainApr 8, 2026
@mdheller
mdheller deleted the codex/resolve-merge-conflicts-in-branch branch April 8, 2026 20:06

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1be5b948fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


# Merge-conflict marker check
rg -n '^(<{7}|={7}|>{7})' .github/PULL_REQUEST_TEMPLATE.md CHANGELOG.md CONTRIBUTING.md README.md asyncapi.agent-plane.patch.yaml asyncapi.yaml examples/community.json examples/rating.json openapi.agent-plane.patch.yaml openapi.yaml schemas/AgentSession.json schemas/Agreement.json schemas/AuthorityLink.json schemas/CapabilityToken.json schemas/Comment.json schemas/Community.json schemas/Connector.json schemas/DataRef.json schemas/DataSphere.json schemas/Dataset.json schemas/EntityField.json schemas/EventEnvelope.json schemas/Exception.json schemas/ExecutionDecision.json schemas/ExecutionSurface.json
git grep -nE '^(<{7}|={7}|>{7})' -- .

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Invert merge-marker validation command

git grep -nE '^(<{7}|={7}|>{7})' -- . returns exit code 1 when no matches are found and 0 when conflict markers are present, so as written this “validation” step fails on clean trees and can pass when markers exist. This is especially problematic if contributors run the listed commands in a set -e shell or CI-style script, because the check’s success condition is backwards.

Useful? React with 👍 / 👎.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mdheller