Uh oh!
There was an error while loading. Please reload this page.
Add support for performant hover and overlay rendering - #40
Open
henryptung wants to merge 3 commits into
Open
Conversation
- visibleLayers can now be specified as a { [string]: string } map.
This allows specification of multiple, differently-styled render
passes based on the same layer data. Is particularly useful for
rendering overlay-style interactive elements (like hover).
- Empty visibleLayers array now means no layers, instead of all layers
shown. Slightly API-breaking, though this seems like the more
consistent value (probably better to treat absent/null as
the special "show all" value, rather than empty array, which
logically seems more like "show none".This allows individual MVTFeatures to be restyled by setting the style on them, then redrawing just the tiles containing the feature (rather than mutating one piece of the style and redrawing the whole layer). This allows for fast hover interaction.
Brought in rbush to accelerate featureAt at high feature scale. This makes it a viable replacement for UtfGrid in hover interaction. Didn't actually implement hover styling here, since I opted to provide custom styling using a combination of mouseover/move/out listeners on the layer and featureAt, as well as the overlay-drawing code from before.
rgwozdz
commented
Dec 18, 2015
Hello @henryptung - we're considering whether we want to merge the non-backward compatible change to the visibleLayers property. Hope to come to consensus in the next few weeks. |
| self._setStyle(self.mvtLayer.style); | ||
| redrawTiles(self); | ||
| this.redraw(); |
There was a problem hiding this comment.
in this context, this.redraw is undefined; it should use self.redraw instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify visibleLayers to allow for mapping.
visibleLayers can now be specified as a { [string]: string } map. This allows specification of multiple, differently-styled render passes based on the same layer data. Is particularly useful for rendering overlay-style interactive elements (like hover).
Empty visibleLayers array now means no layers, instead of all layers shown. Slightly API-breaking, though this seems like the more consistent value (probably better to treat absent/null as the special "show all" value, rather than empty array, which logically seems more like "show none".
Also exposed MVTFeature.redraw method, to allow individual features to be restyled rapidly during hover interaction without redrawing the whole layer (or using a double .toggle() hack).