Skip to content

Fix case sensitivity in PNG chunk identifiers #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kaldaien wants to merge 1 commit into
base: capture_rotated
Choose a base branch
from
Open

Fix case sensitivity in PNG chunk identifiers #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/utility/image.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,13 +922,13 @@
static_cast <uint32_t> (round (active_display.gamut.Yw / 0.00002)));
#endif

SK_PNG_Chunk clli_chunk = { sizeof (clli_data), { 'c','L','L','i' }, &clli_data };
SK_PNG_Chunk clli_chunk = { sizeof (clli_data), { 'c','L','L','I' }, &clli_data };
SK_PNG_Chunk iccp_chunk = { sizeof (SK_PNG_HDR_iCCP_Payload), { 'i','C','C','P' }, &iccp_data };
SK_PNG_Chunk cicp_chunk = { sizeof (cicp_data), { 'c','I','C','P' }, &cicp_data };
SK_PNG_Chunk sbit_chunk = { sizeof (sbit_data), { 's','B','I','T' }, &sbit_data };
SK_PNG_Chunk chrm_chunk = { sizeof (chrm_data), { 'c','H','R','M' }, &chrm_data };
#if 0
SK_PNG_Chunk mdcv_chunk = { sizeof (mdcv_data), { 'm','D','C','v' }, &mdcv_data };
SK_PNG_Chunk mdcv_chunk = { sizeof (mdcv_data), { 'm','D','C','V' }, &mdcv_data };
#endif

iccp_chunk.write (fPNG);
Expand Down Expand Up @@ -2158,7 +2158,7 @@
avif_image->yuvRange = AVIF_RANGE_FULL;

SK_avifRGBImageSetDefaults(&rgb, avif_image);
rgb.rowBytes = pOutputImage->rowPitch;

Check warning on line 2161 in src/utility/image.cpp

View workflow job for this annotation

GitHub Actions / Build 

                                  ^ [D:\a\SKIV\SKIV\SKIV.vcxproj]

Check warning on line 2161 in src/utility/image.cpp

View workflow job for this annotation

GitHub Actions / Build 

       rgb.rowBytes = pOutputImage->rowPitch; [D:\a\SKIV\SKIV\SKIV.vcxproj]

Check warning on line 2161 in src/utility/image.cpp

View workflow job for this annotation

GitHub Actions / Build 

                                  ^ [D:\a\SKIV\SKIV\SKIV.vcxproj]

Check warning on line 2161 in src/utility/image.cpp

View workflow job for this annotation

GitHub Actions / Build 

       rgb.rowBytes = pOutputImage->rowPitch; [D:\a\SKIV\SKIV\SKIV.vcxproj]
rgb.depth = 8;
rgb.ignoreAlpha = false;

Expand Down Expand Up @@ -4724,4 +4724,4 @@
}

PLOG_VERBOSE << "Operation took ~" << (sum_time_parsing + sum_time_getvalue) << " ms.";
}
}
Loading