Skip to content

Wrap overlong lines in Claude wrappers per the 100-char limit - #35

Merged
alexander-yevsyukov merged 2 commits into
masterfrom
claude/funny-benz-71abcf
Jul 17, 2026
Merged

Wrap overlong lines in Claude wrappers per the 100-char limit#35
alexander-yevsyukov merged 2 commits into
masterfrom
claude/funny-benz-71abcf

Conversation

@alexander-yevsyukov

@alexander-yevsyukovalexander-yevsyukov commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Folded every Claude wrapper description: — the four agents and all eleven
    commands — into a > block scalar wrapped near 80 columns. Wording is
    byte-identical (verified by parsing old and new frontmatter and comparing the
    strings), so the descriptions that drive dispatch matching are unaffected.
  • Re-wrapped the overlong body lines in the command wrappers.
  • allowed-tools: lines stay single-line even beyond 100 characters. The
    Claude Code docs define no format for the field beyond single-line examples,
    and its value is machine-consumed as permission rules, so re-wrapping is not
    provably safe across harness versions (a >- scalar folds to a byte-identical
    string under spec YAML, but a live permission-gating check could not be run).
  • docs/authoring-skills.md now records both conventions — a "Claude wrapper
    frontmatter" section (always fold description: near 80 columns; keep
    allowed-tools:/tools: on one line), a matching SKILL.md rules bullet,
    and a "Validate before opening a PR" checklist bullet — so future agent
    sessions apply them without re-deriving.

Why

guidelines/coding.md sets max-line-length: 100, and
guidelines/documentation.md applies it to docs. #34 fixed the newly added
wrappers; this covers the pre-existing ones and makes the convention durable.

Reviewer notes

  • awk 'length($0)>100 {print FILENAME":"FNR}' claude/agents/*.md claude/commands/*.md
    returns exactly the three documented allowed-tools: exemptions
    (dependency-update, raise-coverage, review-docs commands).
  • Coexists with Assign Claude model tiers to skill wrappers #34: the agent edits touch different frontmatter lines than its
    model: changes; expect one trivial adjacent-insertion conflict in
    docs/authoring-skills.md (both add a section after agents/openai.yaml).
    Assign Claude model tiers to skill wrappers #34's new wrappers already match these conventions.
  • pre-pr ran: version gate not applicable, build skipped (Markdown-only),
    review-docs returned APPROVE WITH CHANGES — three cosmetic re-flow
    suggestions (runt last lines), left for maintainer judgment.

🤖 Generated with Claude Code

@alexander-yevsyukov@claude
Wrap overlong lines in Claude wrappers per the 100-char limit
6c35fac
Fold every wrapper `description:` into a `>` block scalar wrapped near
80 columns — wording byte-identical, verified by parsing old and new
frontmatter and comparing the strings — and re-wrap the overlong body
lines in the command wrappers.
`allowed-tools:` lines stay single-line even beyond 100 characters:
the Claude Code docs define no format for the field beyond single-line
examples and a live parsing check could not be run, so re-wrapping a
machine-consumed permission list is not provably safe. The exemption,
and the always-fold `description:` convention, are now recorded in
docs/authoring-skills.md (wrapper-frontmatter section, SKILL.md rules,
and the pre-PR checklist).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings July 16, 2026 21:45
@alexander-yevsyukovalexander-yevsyukov moved this to In Review in v2.0Jul 16, 2026
CopilotAI reviewed Jul 16, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes Claude wrapper Markdown formatting to comply with the repo’s 100-character line-length limit by converting wrapper description: fields to folded block scalars and re-wrapping overlong body lines, and it documents the convention in docs/authoring-skills.md to make it durable for future edits.

Changes:

  • Replaced single-line description: values in Claude command/agent wrappers with wrapped description: > folded scalars.
  • Re-wrapped overlong lines in wrapper bodies while keeping allowed-tools: / agent tools: single-line.
  • Documented the Claude wrapper frontmatter conventions and added validation checklist bullets in docs/authoring-skills.md.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
docs/authoring-skills.mdDocuments wrapper frontmatter wrapping rules and adds a validation checklist note.
claude/commands/write-docs.mdWraps description: into a folded scalar and reflows an overlong body line.
claude/commands/update-copyright.mdWraps description: into a folded scalar and reflows an overlong body line.
claude/commands/run-build.mdWraps description: into a folded scalar and reflows overlong bullet lines.
claude/commands/review-docs.mdWraps description: into a folded scalar.
claude/commands/raise-coverage.mdWraps description: into a folded scalar.
claude/commands/pre-pr.mdWraps description: into a folded scalar.
claude/commands/move-files.mdWraps description: into a folded scalar and reflows an overlong body line.
claude/commands/java-to-kotlin.mdWraps description: into a folded scalar and reflows an overlong body line.
claude/commands/dependency-update.mdWraps description: into a folded scalar and reflows overlong body lines.
claude/commands/bump-version.mdWraps description: into a folded scalar and reflows an overlong body line.
claude/commands/bump-gradle.mdWraps description: into a folded scalar and reflows an overlong body line.
claude/agents/spine-code-review.mdWraps description: into a folded scalar.
claude/agents/review-docs.mdWraps description: into a folded scalar.
claude/agents/kotlin-engineer.mdWraps description: into a folded scalar.
claude/agents/dependency-audit.mdWraps description: into a folded scalar.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threaddocs/authoring-skills.md Outdated
Comment threaddocs/authoring-skills.md Outdated
@alexander-yevsyukov@claude
Use repo-rooted .agents/guidelines paths in the authoring doc
65463b0
The document itself establishes `.agents/guidelines/<file>.md` as the
way to reference shared guidance; the new wrapper-frontmatter prose
used bare `guidelines/...` paths. Addresses Copilot review feedback
on PR #35.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings July 16, 2026 21:50
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Jul 16, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:6c35facc28

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadclaude/commands/bump-gradle.md
Comment threaddocs/authoring-skills.md Outdated
CopilotAI reviewed Jul 16, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

@alexander-yevsyukov
alexander-yevsyukov merged commit 8b14a18 into masterJul 17, 2026
1 check passed
@alexander-yevsyukov
alexander-yevsyukov deleted the claude/funny-benz-71abcf branch July 17, 2026 11:16
@github-project-automationgithub-project-automationBot moved this from In Review to ✅ Done in v2.0Jul 17, 2026
alexander-yevsyukov added a commit that referenced this pull request Jul 17, 2026
@alexander-yevsyukov@claude
Merge origin/master, reconciling wrapper conventions
d8ae9a2
Master's line-wrapping (PR #35) and this branch's model tiers crossed;
the merge keeps master's wrapping style everywhere both sides only
differed in wrap points, plus this branch's semantic changes.
Doc reconciliation: both new sections are kept — "Claude wrappers and
model tiers" (this branch) and "Claude wrapper frontmatter" (master).
Master's allowed-tools bullet said folding was unverified and must be
avoided; this branch has since verified equivalence (strict YAML parse
over every wrapper plus live registration of folded commands), so the
bullet now sanctions both the single-line and folded forms. The four
new commands' short descriptions are folded per master's convention.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@armiolarmiolarmiol approved these changes

Assignees

@alexander-yevsyukovalexander-yevsyukov

Labels

None yet

Projects

v2.0
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexander-yevsyukov@armiol