Uh oh!
There was an error while loading. Please reload this page.
Conversation
scpwais
commented
Jul 24, 2020
@Erkaman@rreusser@dustindorroh@cczarnocki The python notebook now runs on Colab! Since the repo isn't open source, you have to do a few things to get it working:
Now you can go to Runtime > Run All to run all cells, or run them one by one, or whatever you want. |
Erkaman
commented
Jul 31, 2020
"The user provides as parameters a 'max_slop' (a time duration) and a 'max_queue_size' (a number of messages to buffer" buffer? what does this buffer do? its the first time its even mentioned. |
"If topics have messages recorded at somewhat different times (e.g. two sensors both record at 5Hz, but one records 50ms before the other), then MaxSlopTimeSync will find the nearest matches." ok. im interested in how it actually does this. how finds the nearest matches. please write down a short summary of the algorithm used. otherwise, the thing feels like a black-box to me, which i dont like, |
Erkaman
commented
Jul 31, 2020
I can definitely see the utility of using |
Erkaman
commented
Jul 31, 2020
what does the |
Erkaman
commented
Jul 31, 2020
@scpwais left all my feedback above. |
scpwais
commented
Aug 1, 2020
thanks @Erkaman ! Linked in what you read is the MaxSlopTimeSync docs; here's that link again: MaxSlopTimeSync I think that will answer most of your questions. You might also consult the unit tests for MaxSlopTimeSync and for IterProducts. I'll update the notebook a bit to make these more conspicuous. |
scpwais
commented
Aug 1, 2020
"what does the nanos=0 argument do?" -- nanos is nanoseconds |
In this revision:
protobagexamplessubdir@rreusser@Erkaman@dustindorroh@cczarnocki would love your feedback on the python notebook demo. For now it's easiest to just read the version stored on Github (versus try to run it). Here's a permalink to the latest revision at time of writing: https://github.com/StandardCyborg/protobag/blob/aed9ea01d91eaecc838972a0a85bfc4d79b0d6d3/examples/protobag-to-parquet/protobag-demo-full.ipynb