Uh oh!
There was an error while loading. Please reload this page.
feat(procfs): implement /proc/pid/maps and /proc/meminfo - #110
Open
lianux-mm wants to merge 3 commits into
Open
Conversation
This commit implements the standard `/proc/pid/maps` interface and significantly improves the underlying `SeqFile` infrastructure to support large, multi-page content. Key changes: 1. /proc/pid/maps: - Implemented VMA traversal to expose memory layout, permissions, and backing file paths. - Aligned output format strictly with Linux AArch64 standards (12-digit hex addresses, path padding to column 73). - Added automatic identification for [heap] and [stack] regions. 2. SeqFile Infrastructure Improvements: - VFS Size Bypass: Updated `metadata` to report a large virtual file size (1MB) instead of the physical buffer size (4KB). This is a critical fix that prevents the VFS layer from intercepting valid reads as EOF when the offset exceeds the initial buffer size, enabling correct multi-page reading. - Safety: Added `output.fill(0)` in the read path to prevent dirty data leakage into user buffers. - Buffering: Refined the state machine to handle buffer refills and offset tracking robustly. Tested with a VMA stress test (120+ VMAs), confirming that data larger than 4KB can be read sequentially without truncation or corruption.
Author
Test program |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies
This PR depends on the API changes in ArceOS.
I have submitted a corresponding PR to
Starry-OS/arceosto expose the necessary memory interfaces.Upstream PR:
(Note: CI will fail with a fetch error until #39 is merged and the submodule pointer is updated.)
Summary
This PR implements the standard Linux interfaces
/proc/pid/mapsand/proc/meminfofor Starry.Crucially, it also includes significant improvements to the underlying
SeqFileinfrastructure to correctly handle multi-page content generation, resolving issues where output would be truncated at 4KB.Implementation Details
1. /proc/pid/maps
[heap]and[stack].2. /proc/meminfo
axmm.3. SeqFile Infrastructure Improvements (Critical)
metadatato report a large virtual file size (1MB) instead of the physical buffer size. This bypasses the VFS layer's EOF check, allowingcatto read files larger than 4KB (e.g., a process with hundreds of VMAs).output.fill(0)in the read path to prevent dirty data leakage.Test result
1. /proc/pid/maps Validation
mmap) to stress-test theSeqFilepagination logic.2. /proc/meminfo Validation
/proc/meminfois implemented and correctly reports system memory