Skip to content

Timespan Fix - #178

Merged
briandrawert merged 14 commits into
developfrom
tspan-fix
Oct 18, 2021
Merged

Timespan Fix#178
briandrawert merged 14 commits into
developfrom
tspan-fix

Conversation

@BryanRumsey

Copy link
Copy Markdown
Contributor

No description provided.

@BryanRumseyBryanRumsey self-assigned this Oct 12, 2021
@BryanRumseyBryanRumsey linked an issue Oct 12, 2021 that may be closed by this pull request
Comment threadspatialpy/Solver.py Outdated
briandrawert
briandrawert previously approved these changes Oct 12, 2021
@briandrawert
briandrawert self-requested a review October 12, 2021 19:24
@briandrawert
briandrawert dismissed their stale reviewOctober 12, 2021 19:24

Prematurely approved

@briandrawert

Copy link
Copy Markdown
Member

Error in the C++ backend, model.tspan = array([0. , 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1. ]) however, it appears that a .vtk file is generated at every step. The code seg-faulted after creating output7331.vtk

@briandrawert

Copy link
Copy Markdown
Member

Screenshot from 2021-10-12 12-31-56

@BryanRumseyBryanRumsey linked an issue Oct 15, 2021 that may be closed by this pull request
@seanebum
seanebum self-requested a review October 18, 2021 16:45
@briandrawert
briandrawert merged commit 96004a0 into developOct 18, 2021
@briandrawert
briandrawert deleted the tspan-fix branch October 18, 2021 16:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model.tspan and result.tspan are not the same length set timestep size more intelligently

3 participants

@BryanRumsey@briandrawert@seanebum