Skip to content

Initial MinGW compatibility updates - #321

Merged
BryanRumsey merged 2 commits into
developfrom
fix/mingw-thread-compat
Oct 5, 2022
Merged

Initial MinGW compatibility updates#321
BryanRumsey merged 2 commits into
developfrom
fix/mingw-thread-compat

Conversation

@jtcooper10

Copy link
Copy Markdown
Contributor

Some minor tweaks needed to be made to the solver's build code and C++ includes to support MinGW properly.

Changes

  • Added macro config to include math constants on MinGW
  • Updated subprocess calls in solver.py to be cross-platform

- Added macro config to include math constants on MinGW
- Updated subprocess calls in `solver.py` to be cross-platform
@jtcooper10
jtcooper10 marked this pull request as ready for review August 28, 2022 15:58
@briandrawertbriandrawert added this to the 1.1.1 Release milestone Aug 28, 2022
@briandrawertbriandrawert linked an issue Aug 29, 2022 that may be closed by this pull request
@BryanRumseyBryanRumsey mentioned this pull request Oct 4, 2022
@BryanRumsey
BryanRumsey merged commit 2655448 into developOct 5, 2022
@BryanRumsey
BryanRumsey deleted the fix/mingw-thread-compat branch October 5, 2022 15:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Compilation of README model fails

3 participants

@jtcooper10@briandrawert@BryanRumsey