Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Sep 1, 2025. It is now read-only.
Patch requests - #21
Merged
Merged
Conversation
seanhandley
approved these changes
Aug 9, 2019
seanhandley
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Not sure about the hardcoding of values in the specs, though. In RSpec I'd use a let for these, but perhaps here they could be module attributes? Or maybe even something else? WDYT?
| ##################### | ||
| defp response(:get, "https://sandbox-api.stuart.com/timeout") do | ||
| defp response(_, "https://sandbox-api.stuart.com/timeout") do |
Contributor
There was a problem hiding this comment.
The sandbox URL seems like a good candidate for a module attribute.
seanhandley
approved these changes
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for PATCH requests, needed to update jobs:
https://stuart.api-docs.io/v2/jobs/update-a-job