Uh oh!
There was an error while loading. Please reload this page.
feat: add optional verified flag with badge and verification task - #134
Merged
Conversation
Adds an optional verified object (by/on) to the place schema, enforced by npm run validate (missing by, impossible dates, and extra keys all fail). Verified places show a subtle success badge in the pin popup and results list via a shared VerifiedBadge; unverified places are unchanged. Adds a verify-place issue template for the low-barrier contribution type and documents the 12-month (6-month for exam centres) expiry window in data/CONTRIBUTING.md. ClosesStudentSuite#126
Contributor
@AryanSingh is attempting to deploy a commit to the studentsuite Team on Vercel. A member of the Team first needs to authorize it. |
yakew7
marked this pull request as ready for review
August 14, 2026 15:14
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes#126. Every place is shown with equal confidence whether it was checked last week or added a year ago, and the only contribution type is adding a new place — re-checking an existing one is a much smaller ask that nothing records.
Changes
verifiedobject (by+on) on the place record. Existing records are untouched and still validate.scripts/validate-places.mjs):npm run validatenow fails on a malformedverifiedblock — missing/emptyby, a non-ISO or impossibleon(e.g.2026-02-31), or extra keys.Verifiedinterface andPlace.verified?.VerifiedBadgeshows a subtle success pill ("Verified · Jun 2026") in the pin popup and the results list; unverified places render exactly as before..github/ISSUE_TEMPLATE/verify-place.yml(labels: verification) for the low-barrier "verify a place" task.data/CONTRIBUTING.mddocuments the field, the expiry window (12 months; 6 months for exam centres), and updates the old "do not add verified date to the JSON" rule (this field is the exception, Add a verified flag to places and a verification contributor task #126).Verification
npm run validatepasses unchanged; with a validverifiedblock; and fails with clear messages for missingby,2026-02-31, and an extra key (each verified by editing a temp record, then reverted).tsc --noEmit,eslint, andnext buildall clean.