refactor(errors): standardize safe unknown-error normalization - #371
Merged
karagozemin merged 3 commits intoSep 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize first-party error conversion on
@sub-rosa/logging/errors, preserving domain exceptions and their causes while separating operator diagnostics from fixed HTTP/UI messages. Add recursive credential redaction and bounded handling of cycles, bigint, hostile accessors, proxies and nested causes. Migrate runtime, UI and operational catch boundaries; document the inventory and enforce it with an AST guard in CI.Closes #238.
Validation: all affected workspace test suites and
pnpm -r --if-present typecheckpassed;pnpm errors:normalize:test,pnpm errors:normalize:check, and the logging guard passed. Existing tlock tests read public Drand data; no live payments or transaction submissions were performed. Keeper tests now assert safe public failure copy and consistent plain-object normalization.