Uh oh!
There was an error while loading. Please reload this page.
[Refactor:Developer] Replace submitty_count - #56
Conversation
roye2
left a comment
There was a problem hiding this comment.
I noted some small fixes that need to be made.
There was a problem hiding this comment.
I am concerned that anything testing this gradeable will be expecting autograding results. But, it does look like the cypress spec 'verify_tutorial_courses' only checks if you can submit, so it should be fine.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
roye2
left a comment
There was a problem hiding this comment.
I tested all 3 gradeables affected by this change. 04 python static analysis and 06 loop types look good and behave the same way before and after the changes from this PR. As for 07 loop depth, we will just need to make sure that turning off autograding for it doesn't break any testing or anything.
Uh oh!
There was an error while loading. Please reload this page.
What is the current behavior?
Fixes Submitty Issue#11784 - This one of the companion PRs to Submitty PR#12609.
The tutorial courses 04 - Python Static Analysis, 06 - Loop Types, and 07 - Loop Depth all use
submitty_countin their autograding configs. This command is being deprecated, so we should update it.What is the new behavior?
submitty_counthas been removed from04 - Python Static Analysisand06 - Loop Typesand replaced withsubmitty_count_tsin preparation for deprecation. For07 - Loop Depth, there was no equivalent functionality present insubmitty_count_tsso the testcase is entirely commented out.Other information?
This specific PR is not a breaking change. However, the other PRs accompanying this one are breaking PRs.
Tested that all homework configs still build and their accompanying still submissions work as intended.