Uh oh!
There was an error while loading. Please reload this page.
Websocket - Add events (OnConnect / OnDisconnect) - #86
Open
Apolixit wants to merge 7 commits into
Open
Conversation
Apolixit
commented
Jul 9, 2024
MemberAuthor
@RostislavLitovkin, based on your issue, I have added OnConnect and OnDisconnect, but I didn't implemented the others because I think it is better if it is handle by the caller (maybe some apps doesn't want auto-reconnect) You can try this PR on your app before to merge if you prefer ;) |
RostislavLitovkin
approved these changes
Jul 15, 2024
darkfriend77
requested changes
Jul 16, 2024
darkfriend77
left a comment
Member
There was a problem hiding this comment.
We should make sure that we use the events from the integrated frameworks like vs-streamjsonrpc and the websocket it self, there is also the underlying httpclient maybe.
Uh oh!
There was an error while loading. Please reload this page.
# Conflicts: # Substrate.NetApi/SubstrateClient.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to #83