Skip to content
This repository was archived by the owner on Jul 4, 2026. It is now read-only.

fix: resolve ruff lint errors in validation.py and test_validation.py#1

Merged
SummerOneTwo merged 1 commit into from
Apr 24, 2026
Merged

fix: resolve ruff lint errors in validation.py and test_validation.py #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/autocode_mcp/tools/validation.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -316,7 +316,7 @@ def _compare_output(self, actual: str, expected: str, tolerance: float) -> bool:
if len(actual_tokens) == len(expected_tokens):
actual_nums = [float(x) for x in actual_tokens]
expected_nums = [float(x) for x in expected_tokens]
return all(abs(a - e) < tolerance for a, e in zip(actual_nums, expected_nums))
return all(abs(a - e) < tolerance for a, e in zip(actual_nums, expected_nums, strict=False))

CopilotAIApr 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you already guard on len(actual_tokens) == len(expected_tokens), so using zip(..., strict=False) is redundant and slightly undermines the intent of being explicit about length mismatches. Consider strict=True (or rely on strict=True and drop the manual length check) to keep this float-compare path self-consistent.

Suggested change
returnall(abs(a-e) <tolerancefora, einzip(actual_nums, expected_nums, strict=False))
returnall(abs(a-e) <tolerancefora, einzip(actual_nums, expected_nums, strict=True))

Copilot uses AI. Check for mistakes.
except ValueError:
pass

Expand DownExpand Up@@ -364,7 +364,7 @@ def _extract_samples_from_readme(self, readme_path: str) -> list[dict]:
output_blocks = re.findall(pattern, content, re.DOTALL | re.IGNORECASE)

# 配对
for i, (inp, out) in enumerate(zip(input_blocks, output_blocks)):
for _i, (inp, out) in enumerate(zip(input_blocks, output_blocks, strict=False)):

CopilotAIApr 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_i is unused in this loop; since the index isn’t used, dropping enumerate(...) entirely (or using _ instead of _i) would make the intent clearer and avoid carrying an unused variable.

Suggested change
for_i, (inp, out)inenumerate(zip(input_blocks, output_blocks, strict=False)):
forinp, outinzip(input_blocks, output_blocks, strict=False):

Copilot uses AI. Check for mistakes.
samples.append({
"input": inp.strip(),
"expected_output": out.strip(),
Expand DownExpand Up@@ -392,10 +392,10 @@ def _extract_samples_from_readme(self, readme_path: str) -> list[dict]:
inputs = re.findall(input_pattern, content, re.DOTALL | re.IGNORECASE)
outputs = re.findall(output_pattern, content, re.DOTALL | re.IGNORECASE)

for inp, out in zip(inputs, outputs):
for inp, out in zip(inputs, outputs, strict=False):
samples.append({
"input": inp.strip(),
"expected_output": out.strip(),
})

return samples
return samples
2 changes: 0 additions & 2 deletions tests/test_validation.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,8 +7,6 @@
import os
import tempfile

import pytest

from autocode_mcp.tools.validation import ProblemValidateTool


Expand Down
Loading